[Chore](build) add -Wconversion and remove some unused code (#33127)

add -Wconversion and remove some unused code
This commit is contained in:
Pxl
2024-04-03 11:57:41 +08:00
committed by yiguolei
parent 6798a24a27
commit 8fd6d4c41b
68 changed files with 115 additions and 240 deletions

View File

@ -319,29 +319,6 @@ MutableColumnPtr ColumnStruct::get_shrinked_column() {
return ColumnStruct::create(std::move(new_columns));
}
MutableColumns ColumnStruct::scatter(ColumnIndex num_columns, const Selector& selector) const {
const size_t tuple_size = columns.size();
std::vector<MutableColumns> scattered_tuple_elements(tuple_size);
for (size_t tuple_element_idx = 0; tuple_element_idx < tuple_size; ++tuple_element_idx) {
scattered_tuple_elements[tuple_element_idx] =
columns[tuple_element_idx]->scatter(num_columns, selector);
}
MutableColumns res(num_columns);
for (size_t scattered_idx = 0; scattered_idx < num_columns; ++scattered_idx) {
MutableColumns new_columns(tuple_size);
for (size_t tuple_element_idx = 0; tuple_element_idx < tuple_size; ++tuple_element_idx) {
new_columns[tuple_element_idx] =
std::move(scattered_tuple_elements[tuple_element_idx][scattered_idx]);
}
res[scattered_idx] = ColumnStruct::create(std::move(new_columns));
}
return res;
}
void ColumnStruct::reserve(size_t n) {
const size_t tuple_size = columns.size();
for (size_t i = 0; i < tuple_size; ++i) {