database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[refactor](functioncontext) remove duplicate type definition in function context (#17421)

Browse Source 
remove duplicate type definition in function context
remove unused method in function context
not need stale state in vexpr context because vexpr is stateless and function context saves state and they are cloned.
remove useless slot_size in all tuple or slot descriptor.
remove doris_udf namespace, it is useless.
remove some unused macro definitions.
init v_conjuncts in vscanner, not need write the same code in every scanner.
using unique ptr to manage function context since it could only belong to a single expr context.
Issue Number: close #xxx
---------

Co-authored-by: yiguolei <yiguolei@gmail.com>
This commit is contained in:
yiguolei
2023-03-06 16:07:09 +08:00
committed by GitHub
parent e7cba11680
commit 9477c48ef8
57 changed files with 176 additions and 1452 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
be/test/vec/function/function_test_util.cpp
View File

@ -50,7 +50,7 @@ uint64_t str_to_datetime_v2(std::string datetime_str, std::string datetime_forma
size_t type_index_to_data_type(const std::vector<AnyType>& input_types, size_t index,
ut_type::UTDataTypeDesc& ut_desc, DataTypePtr& type) {
doris_udf::FunctionContext::TypeDesc& desc = ut_desc.type_desc;
doris::TypeDescriptor& desc = ut_desc.type_desc;
if (index >= input_types.size()) {
return -1;
}
@ -73,71 +73,71 @@ size_t type_index_to_data_type(const std::vector<AnyType>& input_types, size_t i
switch (tp) {
case TypeIndex::String:
desc.type = doris_udf::FunctionContext::TYPE_STRING;
desc.type = doris::PrimitiveType::TYPE_STRING;
type = std::make_shared<DataTypeString>();
return 1;
case TypeIndex::JSONB:
desc.type = doris_udf::FunctionContext::TYPE_JSONB;
desc.type = doris::PrimitiveType::TYPE_JSONB;
type = std::make_shared<DataTypeJsonb>();
return 1;
case TypeIndex::BitMap:
desc.type = doris_udf::FunctionContext::TYPE_OBJECT;
desc.type = doris::PrimitiveType::TYPE_OBJECT;
type = std::make_shared<DataTypeBitMap>();
return 1;
case TypeIndex::UInt8:
desc.type = doris_udf::FunctionContext::TYPE_BOOLEAN;
desc.type = doris::PrimitiveType::TYPE_BOOLEAN;
type = std::make_shared<DataTypeUInt8>();
return 1;
case TypeIndex::Int8:
desc.type = doris_udf::FunctionContext::TYPE_TINYINT;
desc.type = doris::PrimitiveType::TYPE_TINYINT;
type = std::make_shared<DataTypeInt8>();
return 1;
case TypeIndex::Int16:
desc.type = doris_udf::FunctionContext::TYPE_SMALLINT;
desc.type = doris::PrimitiveType::TYPE_SMALLINT;
type = std::make_shared<DataTypeInt16>();
return 1;
case TypeIndex::Int32:
desc.type = doris_udf::FunctionContext::TYPE_INT;
desc.type = doris::PrimitiveType::TYPE_INT;
type = std::make_shared<DataTypeInt32>();
return 1;
case TypeIndex::Int64:
desc.type = doris_udf::FunctionContext::TYPE_BIGINT;
desc.type = doris::PrimitiveType::TYPE_BIGINT;
type = std::make_shared<DataTypeInt64>();
return 1;
case TypeIndex::Int128:
desc.type = doris_udf::FunctionContext::TYPE_LARGEINT;
desc.type = doris::PrimitiveType::TYPE_LARGEINT;
type = std::make_shared<DataTypeInt128>();
return 1;
case TypeIndex::Float32:
desc.type = doris_udf::FunctionContext::TYPE_FLOAT;
desc.type = doris::PrimitiveType::TYPE_FLOAT;
type = std::make_shared<DataTypeFloat32>();
return 1;
case TypeIndex::Float64:
desc.type = doris_udf::FunctionContext::TYPE_DOUBLE;
desc.type = doris::PrimitiveType::TYPE_DOUBLE;
type = std::make_shared<DataTypeFloat64>();
return 1;
case TypeIndex::Decimal128:
desc.type = doris_udf::FunctionContext::TYPE_DECIMALV2;
desc.type = doris::PrimitiveType::TYPE_DECIMALV2;
type = std::make_shared<DataTypeDecimal<Decimal128>>();
return 1;
case TypeIndex::DateTime:
desc.type = doris_udf::FunctionContext::TYPE_DATETIME;
desc.type = doris::PrimitiveType::TYPE_DATETIME;
type = std::make_shared<DataTypeDateTime>();
return 1;
case TypeIndex::Date:
desc.type = doris_udf::FunctionContext::TYPE_DATE;
desc.type = doris::PrimitiveType::TYPE_DATE;
type = std::make_shared<DataTypeDate>();
return 1;
case TypeIndex::DateV2:
desc.type = doris_udf::FunctionContext::TYPE_DATEV2;
desc.type = doris::PrimitiveType::TYPE_DATEV2;
type = std::make_shared<DataTypeDateV2>();
return 1;
case TypeIndex::DateTimeV2:
desc.type = doris_udf::FunctionContext::TYPE_DATETIMEV2;
desc.type = doris::PrimitiveType::TYPE_DATETIMEV2;
type = std::make_shared<DataTypeDateTimeV2>();
return 1;
case TypeIndex::Array: {
desc.type = doris_udf::FunctionContext::TYPE_ARRAY;
desc.type = doris::PrimitiveType::TYPE_ARRAY;
ut_type::UTDataTypeDesc sub_desc;
DataTypePtr sub_type = nullptr;
++index;