database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](nereids)AssertNumRow node's output should be nullable (#32136)

Browse Source 
Co-authored-by: Co-Author Jerry Hu <mrhhsg@gmail.com>
This commit is contained in:
starocean999
2024-03-15 17:07:27 +08:00
committed by yiguolei
parent c0776c7c07
commit 97b35d6830
21 changed files with 392 additions and 324 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
be/src/vec/exec/vassert_num_rows_node.cpp
View File

@ -30,6 +30,7 @@
#include "runtime/runtime_state.h"
#include "vec/core/block.h"
#include "vec/exprs/vexpr_context.h"
#include "vec/utils/util.hpp"
namespace doris {
class DescriptorTbl;
@ -48,6 +49,10 @@ VAssertNumRowsNode::VAssertNumRowsNode(ObjectPool* pool, const TPlanNode& tnode,
} else {
_assertion = TAssertion::LE; // just compatible for the previous code
}
_should_convert_output_to_nullable =
tnode.assert_num_rows_node.__isset.should_convert_output_to_nullable &&
tnode.assert_num_rows_node.should_convert_output_to_nullable;
}
Status VAssertNumRowsNode::open(RuntimeState* state) {
@ -61,12 +66,14 @@ Status VAssertNumRowsNode::open(RuntimeState* state) {
Status VAssertNumRowsNode::pull(doris::RuntimeState* state, vectorized::Block* block, bool* eos) {
_num_rows_returned += block->rows();
bool assert_res = false;
const auto has_more_rows = !(*eos);
switch (_assertion) {
case TAssertion::EQ:
assert_res = _num_rows_returned == _desired_num_rows;
assert_res = _num_rows_returned == _desired_num_rows ||
(has_more_rows && _num_rows_returned < _desired_num_rows);
break;
case TAssertion::NE:
assert_res = _num_rows_returned != _desired_num_rows;
assert_res = _num_rows_returned != _desired_num_rows || has_more_rows;
break;
case TAssertion::LT:
assert_res = _num_rows_returned < _desired_num_rows;
@ -75,19 +82,47 @@ Status VAssertNumRowsNode::pull(doris::RuntimeState* state, vectorized::Block* b
assert_res = _num_rows_returned <= _desired_num_rows;
break;
case TAssertion::GT:
assert_res = _num_rows_returned > _desired_num_rows;
assert_res = _num_rows_returned > _desired_num_rows || has_more_rows;
break;
case TAssertion::GE:
assert_res = _num_rows_returned >= _desired_num_rows;
assert_res = _num_rows_returned >= _desired_num_rows || has_more_rows;
break;
default:
break;
}
/**
* For nereids planner:
* The output of `AssertNumRowsOperatorX` should be nullable.
* If the `_num_rows_returned` is 0 and `_desired_num_rows` is 1,
* here need to insert one row of null.
*/
if (_should_convert_output_to_nullable) {
if (block->rows() > 0) {
for (size_t i = 0; i != block->columns(); ++i) {
auto& data = block->get_by_position(i);
data.type = vectorized::make_nullable(data.type);
data.column = vectorized::make_nullable(data.column);
}
} else if (!has_more_rows && _assertion == TAssertion::EQ && _num_rows_returned == 0 &&
_desired_num_rows == 1) {
auto new_block =
vectorized::VectorizedUtils::create_columns_with_type_and_name(_row_descriptor);
block->swap(new_block);
for (size_t i = 0; i != block->columns(); ++i) {
auto& column = block->get_by_position(i).column;
auto& type = block->get_by_position(i).type;
type = vectorized::make_nullable(type);
column = type->create_column();
column->assume_mutable()->insert_default();
}
assert_res = true;
}
}
if (!assert_res) {
auto to_string_lambda = [](TAssertion::type assertion) {
std::map<int, const char*>::const_iterator it =
_TAssertion_VALUES_TO_NAMES.find(assertion);
auto it = _TAssertion_VALUES_TO_NAMES.find(assertion);
if (it == _TAggregationOp_VALUES_TO_NAMES.end()) {
return "NULL";