database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](fe) Fix the default value of ReplacePartitionClause.isStrictRange (#38688) (#38879)

Browse Source
This commit is contained in:
walter
2024-08-05 20:59:50 +08:00
committed by GitHub
parent ce75e6adfe
commit 9c020f9db1
1 changed files with 17 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
fe/fe-core/src/main/java/org/apache/doris/analysis/ReplacePartitionClause.java
View File

@ -61,6 +61,15 @@ public class ReplacePartitionClause extends AlterTableClause {
this.tempPartitionNames = tempPartitionNames;
this.needTableStable = false;
this.properties = properties;
// ATTN: During ReplacePartitionClause.analyze(), the default value of isStrictRange is true.
// However, ReplacePartitionClause instances constructed by internal code do not call analyze(),
// so their isStrictRange value is incorrect (e.g., INSERT INTO ... OVERWRITE).
//
// Considering this, we should handle the relevant properties when constructing.
this.isStrictRange = getBoolProperty(properties, PropertyAnalyzer.PROPERTIES_STRICT_RANGE, true);
this.useTempPartitionName = getBoolProperty(
properties, PropertyAnalyzer.PROPERTIES_USE_TEMP_PARTITION_NAME, false);
}
public List<String> getPartitionNames() {
@ -131,4 +140,12 @@ public class ReplacePartitionClause extends AlterTableClause {
public String toString() {
return toSql();
}
public static boolean getBoolProperty(Map<String, String> properties, String propKey, boolean defaultVal) {
if (properties != null && properties.containsKey(propKey)) {
String val = properties.get(propKey);
return Boolean.parseBoolean(val);
}
return defaultVal;
}
}