database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](udf) avoid exception when fail to find udf in replay logic (#25965)

Browse Source 
When replaying drop function edit log, the function may not be found, causing runtime exception and
FE will fail to start.
The function SHOULD be exist, but the reason is still unknown.
I change the logic to NOT throw exception if function is not found.
This is a workaround to make sure FE can start, and add some log for later debug.
This commit is contained in:
Mingyu Chen
2023-10-26 21:19:13 +08:00
committed by GitHub
parent a2a157fcde
commit 9faa6e083b
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
fe/fe-core/src/main/java/org/apache/doris/catalog/Database.java
View File

@ -740,13 +740,20 @@ public class Database extends MetaObject implements Writable, DatabaseIf<Table>
if (FunctionUtil.dropFunctionImpl(function, ifExists, name2Function)) {
Env.getCurrentEnv().getEditLog().logDropFunction(function);
FunctionUtil.dropFromNereids(this.getFullName(), function);
LOG.info("finished to drop function {}", function.getName().getFunction());
}
}
public synchronized void replayDropFunction(FunctionSearchDesc functionSearchDesc) {
try {
FunctionUtil.dropFunctionImpl(functionSearchDesc, false, name2Function);
// Set ifExists to true to avoid throw exception if function is not found.
// It should not happen but the reason is unknown, so add warn log for debug.
if (!FunctionUtil.dropFunctionImpl(functionSearchDesc, true, name2Function)) {
LOG.warn("failed to find function to drop: {} when replay, skip",
functionSearchDesc.getName().getFunction());
}
FunctionUtil.dropFromNereids(this.getFullName(), functionSearchDesc);
LOG.info("finished to replay drop function {}", functionSearchDesc.getName().getFunction());
} catch (UserException e) {
throw new RuntimeException(e);
}