database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug](javaudf) fix BE crash if javaudf is push down (#21139)

Browse Source
This commit is contained in:
Gabriel
2023-06-28 15:01:24 +08:00
committed by GitHub
parent 1fc1e76fc7
commit a4fdf7324a
6 changed files with 177 additions and 141 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
be/src/vec/functions/function_java_udf.h
View File

@ -23,6 +23,7 @@
#include <stdint.h>
#include <memory>
#include <mutex>
#include <ostream>
#include "common/logging.h"
@ -83,13 +84,6 @@ private:
const DataTypes _argument_types;
const DataTypePtr _return_type;
/// Global class reference to the UdfExecutor Java class and related method IDs. Set in
/// Init(). These have the lifetime of the process (i.e. 'executor_cl_' is never freed).
jclass executor_cl_;
jmethodID executor_ctor_id_;
jmethodID executor_evaluate_id_;
jmethodID executor_close_id_;
struct IntermediateState {
size_t buffer_size;
size_t row_idx;
@ -97,6 +91,15 @@ private:
IntermediateState() : buffer_size(0), row_idx(0) {}
};
struct JniEnv {
/// Global class reference to the UdfExecutor Java class and related method IDs. Set in
/// Init(). These have the lifetime of the process (i.e. 'executor_cl_' is never freed).
jclass executor_cl;
jmethodID executor_ctor_id;
jmethodID executor_evaluate_id;
jmethodID executor_close_id;
};
struct JniContext {
// Do not save parent directly, because parent is in VExpr, but jni context is in FunctionContext
// The deconstruct sequence is not determined, it will core.
@ -124,9 +127,9 @@ private:
// intermediate_state includes two parts: reserved / used buffer size and rows
std::unique_ptr<IntermediateState> output_intermediate_state_ptr;
JniContext(int64_t num_args, JavaFunctionCall* parent)
: executor_cl_(parent->executor_cl_),
executor_close_id_(parent->executor_close_id_),
JniContext(int64_t num_args, jclass executor_cl, jmethodID executor_close_id)
: executor_cl_(executor_cl),
executor_close_id_(executor_close_id),
input_values_buffer_ptr(new int64_t[num_args]),
input_nulls_buffer_ptr(new int64_t[num_args]),
input_offsets_ptrs(new int64_t[num_args]),