database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](vectorized) fix core dump on get_json_string and add some ut (#8496)

Browse Source
This commit is contained in:
Pxl
2022-03-17 10:08:31 +08:00
committed by GitHub
parent 848acec584
commit a8af8d2981
22 changed files with 145 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
be/src/vec/functions/function_json.cpp
View File

@ -46,7 +46,9 @@ void char_split(std::vector<T>& res, const U& var, char p) {
int pos = start;
int end = var.length();
while (pos < end) {
while (var[pos] != p && pos < end) pos++;
while (var[pos] != p && pos < end) {
pos++;
}
res.emplace_back(&var[start], pos - start);
pos++;
start = pos;
@ -325,7 +327,7 @@ struct GetJsonString {
const auto l_raw = reinterpret_cast<const char*>(&ldata[loffsets[i - 1]]);
int r_size = roffsets[i] - roffsets[i - 1] - 1;
const auto r_raw = reinterpret_cast<const char*>(&rdata[loffsets[i - 1]]);
const auto r_raw = reinterpret_cast<const char*>(&rdata[roffsets[i - 1]]);
if (null_map[i]) {
StringOP::push_null_string(i, res_data, res_offsets, null_map);
@ -342,7 +344,6 @@ struct GetJsonString {
const int max_string_len = 65535;
if (root == nullptr || root->IsNull()) {
null_map[i] = 1;
StringOP::push_null_string(i, res_data, res_offsets, null_map);
} else if (root->IsString()) {
const auto ptr = root->GetString();