database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Fix disks_total_capacity metric bug (#2988)

Browse Source 
Now disks_total_capacity metric is a user specified capacity, but
disks_avail_capacity is the disk's actual available capacity, so
disks_total_capacity may be less than disks_avail_capacity, and
UsedPct on FE may be a negative number as a result.
We'd better to use disk actual capacity for disks_total_capacity metric.
This commit is contained in:
Yingchun Lai
2020-03-02 19:09:50 +08:00
committed by GitHub
parent 511c5eed50
commit aa58cd99d9
4 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
be/src/olap/storage_engine.cpp
View File

@ -257,7 +257,7 @@ OLAPStatus StorageEngine::get_all_data_dir_info(vector<DataDirInfo>* data_dir_in
MonotonicStopWatch timer;
timer.start();
// 1. update avaiable capacity of each data dir
// 1. update available capacity of each data dir
// get all root path info and construct a path map.
// path -> DataDirInfo
std::map<std::string, DataDirInfo> path_map;
@ -553,7 +553,7 @@ OLAPStatus StorageEngine::_start_trash_sweep(double* usage) {
continue;
}
double curr_usage = (double) (info.capacity - info.available) / info.capacity;
double curr_usage = (double) (info.disk_capacity - info.available) / info.disk_capacity;
*usage = *usage > curr_usage ? *usage : curr_usage;
OLAPStatus curr_res = OLAP_SUCCESS;