From ab64dbe65d006e2519f2e73fd23749c41c6b3fb9 Mon Sep 17 00:00:00 2001 From: xinghuayu007 <1450306854@qq.com> Date: Wed, 21 Apr 2021 09:23:12 +0800 Subject: [PATCH] not need to deserialize again (#5644) Co-authored-by: wangxixu --- be/src/olap/rowset/rowset_meta_manager.cpp | 1 - be/src/olap/tablet_meta.cpp | 6 ------ be/src/olap/tablet_meta_manager.cpp | 6 ------ 3 files changed, 13 deletions(-) diff --git a/be/src/olap/rowset/rowset_meta_manager.cpp b/be/src/olap/rowset/rowset_meta_manager.cpp index 4ed988d953..d7ffa96492 100644 --- a/be/src/olap/rowset/rowset_meta_manager.cpp +++ b/be/src/olap/rowset/rowset_meta_manager.cpp @@ -85,7 +85,6 @@ OLAPStatus RowsetMetaManager::save(OlapMeta* meta, TabletUid tablet_uid, const R std::string key = ROWSET_PREFIX + tablet_uid.to_string() + "_" + rowset_id.to_string(); std::string value; bool ret = rowset_meta_pb.SerializeToString(&value); - ; if (!ret) { std::string error_msg = "serialize rowset pb failed. rowset id:" + key; LOG(WARNING) << error_msg; diff --git a/be/src/olap/tablet_meta.cpp b/be/src/olap/tablet_meta.cpp index e691aa2d75..1acf76c466 100644 --- a/be/src/olap/tablet_meta.cpp +++ b/be/src/olap/tablet_meta.cpp @@ -304,12 +304,6 @@ OLAPStatus TabletMeta::serialize(string* meta_binary) { if (!serialize_success) { LOG(FATAL) << "failed to serialize meta " << full_name(); } - // deserialize the meta to check the result is correct - TabletMetaPB de_tablet_meta_pb; - bool parsed = de_tablet_meta_pb.ParseFromString(*meta_binary); - if (!parsed) { - LOG(FATAL) << "deserialize from previous serialize result failed " << full_name(); - } return OLAP_SUCCESS; } diff --git a/be/src/olap/tablet_meta_manager.cpp b/be/src/olap/tablet_meta_manager.cpp index e6de35e15d..27775f8118 100644 --- a/be/src/olap/tablet_meta_manager.cpp +++ b/be/src/olap/tablet_meta_manager.cpp @@ -104,12 +104,6 @@ OLAPStatus TabletMetaManager::save(DataDir* store, TTabletId tablet_id, TSchemaH VLOG_NOTICE << "save tablet meta to meta store: key = " << key; OlapMeta* meta = store->get_meta(); - TabletMetaPB de_tablet_meta_pb; - bool parsed = de_tablet_meta_pb.ParseFromString(meta_binary); - if (!parsed) { - LOG(FATAL) << "deserialize from previous serialize result failed"; - } - LOG(INFO) << "save tablet meta " << ", key:" << key << " meta_size=" << meta_binary.length(); return meta->put(META_COLUMN_FAMILY_INDEX, key, meta_binary);