database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](decimalv2) avoid crashing caused by decimalv2 arithmetic with check_overflow_for_decimal enabled (#28219)

Browse Source
This commit is contained in:
Jerry Hu
2023-12-12 20:32:10 +08:00
committed by GitHub
parent 5c1d69de70
commit ace2b45c37
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
be/src/vec/functions/function_binary_arithmetic.h
View File

@ -961,6 +961,8 @@ public:
}
bool check_overflow_for_decimal = context->check_overflow_for_decimal();
auto status = Status::RuntimeError("{}'s arguments do not match the expected data types",
get_name());
bool valid = cast_both_types(
left_generic, right_generic, result_generic,
[&](const auto& left, const auto& right, const auto& res) {
@ -978,6 +980,13 @@ public:
(IsDataTypeDecimal<LeftDataType> ||
IsDataTypeDecimal<RightDataType>))) {
if (check_overflow_for_decimal) {
if constexpr ((IsDecimalV2<typename LeftDataType::FieldType> ||
IsDecimalV2<typename RightDataType::
FieldType>)&&!is_to_null_type) {
status = Status::Error<ErrorCode::NOT_IMPLEMENTED_ERROR>(
"cannot check overflow with decimalv2");
return false;
}
auto column_result = ConstOrVectorAdapter<
LeftDataType, RightDataType,
std::conditional_t<IsDataTypeDecimal<ExpectedResultDataType>,
@ -1007,8 +1016,7 @@ public:
return false;
});
if (!valid) {
return Status::RuntimeError("{}'s arguments do not match the expected data types",
get_name());
return status;
}
return Status::OK();