database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[opt](Nereids) speed up deepEquals of TreeNode (#23710)

Browse Source
This commit is contained in:
morrySnow
2023-08-31 19:38:44 +08:00
committed by GitHub
parent 3a34ec95af
commit b5e8217743
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/TreeNode.java
View File

@ -231,9 +231,9 @@ public interface TreeNode<NODE_TYPE extends TreeNode<NODE_TYPE>> {
* @param that other tree node
* @return true if all the tree is equals
*/
default boolean deepEquals(TreeNode that) {
Deque<TreeNode> thisDeque = new ArrayDeque<>();
Deque<TreeNode> thatDeque = new ArrayDeque<>();
default boolean deepEquals(TreeNode<?> that) {
Deque<TreeNode<?>> thisDeque = new ArrayDeque<>();
Deque<TreeNode<?>> thatDeque = new ArrayDeque<>();
thisDeque.push(this);
thatDeque.push(that);
@ -244,8 +244,13 @@ public interface TreeNode<NODE_TYPE extends TreeNode<NODE_TYPE>> {
return false;
}
TreeNode currentNodeThis = thisDeque.pop();
TreeNode currentNodeThat = thatDeque.pop();
TreeNode<?> currentNodeThis = thisDeque.pop();
TreeNode<?> currentNodeThat = thatDeque.pop();
// since TreeNode is immutable, use == to short circuit
if (currentNodeThis == currentNodeThat) {
continue;
}
// If current nodes are not equal or the number of child nodes differ, return false.
if (!currentNodeThis.equals(currentNodeThat)