database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug] Fix BE crash when input to hll_merge is null (#3521)

Browse Source
This commit is contained in:
Dayue Gao
2020-05-09 11:01:48 +08:00
committed by GitHub
parent e2c3c84e8d
commit b62b310864
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
be/src/exprs/hll_function.cpp
View File

@ -64,6 +64,9 @@ void HllFunctions::hll_update(FunctionContext *, const T &src, StringVal* dst) {
}
void HllFunctions::hll_merge(FunctionContext*, const StringVal& src, StringVal* dst) {
if (src.is_null) {
return;
}
auto* dst_hll = reinterpret_cast<HyperLogLog*>(dst->ptr);
// zero size means the src input is a agg object
if (src.len == 0) {
@ -81,6 +84,9 @@ BigIntVal HllFunctions::hll_finalize(FunctionContext*, const StringVal &src) {
}
BigIntVal HllFunctions::hll_get_value(FunctionContext*, const StringVal &src) {
if (src.is_null) {
return BigIntVal::null();
}
auto* src_hll = reinterpret_cast<HyperLogLog*>(src.ptr);
BigIntVal result(src_hll->estimate_cardinality());
return result;