[Chore](build) enable -Wextra and remove some -Wno (#15760)

enable -Wextra and remove some -Wno
2023-01-15 10:40:35 +08:00
parent fd0c352144
commit b727033906
28 changed files with 60 additions and 75 deletions
--- a/be/src/util/bfd_parser.cpp
+++ b/be/src/util/bfd_parser.cpp
@ -102,9 +102,12 @@ BfdParser* BfdParser::create() {
    }

    char prog_name[1024];
-    // Ignore unused return value
-    if (fscanf(file, "%1023s ", prog_name))
-        ;
+
+    if (fscanf(file, "%1023s ", prog_name) != 1) {
+        fclose(file);
+        return nullptr;
+    }
+
    fclose(file);
    std::unique_ptr<BfdParser> parser(new BfdParser(prog_name));
    if (parser->parse()) {