database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Optimize] use string_view instead of std::string in string function (#6010)

Browse Source
This commit is contained in:
stdpain
2021-06-16 09:40:13 +08:00
committed by GitHub
parent daf8ce29ca
commit bde60280b8
12 changed files with 67 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
be/src/exprs/string_functions.cpp
View File

@ -23,6 +23,7 @@
#include "exprs/anyval_util.h"
#include "exprs/expr.h"
#include "fmt/format.h"
#include "math_functions.h"
#include "runtime/string_value.hpp"
#include "runtime/tuple_row.h"
@ -896,7 +897,7 @@ StringVal StringFunctions::money_format(FunctionContext* context, const DecimalV
DecimalValue rounded;
DecimalValue::from_decimal_val(v).round(&rounded, 2, HALF_UP);
DecimalValue tmp(std::string("100"));
DecimalValue tmp(std::string_view("100"));
DecimalValue result = rounded * tmp;
return do_money_format(context, result.to_string());
}
@ -908,7 +909,7 @@ StringVal StringFunctions::money_format(FunctionContext* context, const DecimalV
DecimalV2Value rounded;
DecimalV2Value::from_decimal_val(v).round(&rounded, 2, HALF_UP);
DecimalV2Value tmp(std::string("100"));
DecimalV2Value tmp(std::string_view("100"));
DecimalV2Value result = rounded * tmp;
return do_money_format(context, result.to_string());
}
@ -918,8 +919,7 @@ StringVal StringFunctions::money_format(FunctionContext* context, const BigIntVa
return StringVal::null();
}
std::string cent_money = std::to_string(v.val) + std::string("00");
return do_money_format(context, cent_money);
return do_money_format(context, fmt::format("{}00", v.val, "00"));
}
StringVal StringFunctions::money_format(FunctionContext* context, const LargeIntVal& v) {
@ -927,9 +927,7 @@ StringVal StringFunctions::money_format(FunctionContext* context, const LargeInt
return StringVal::null();
}
std::stringstream ss;
ss << v.val << "00";
return do_money_format(context, ss.str());
return do_money_format(context, fmt::format("{}00", v.val, "00"));
}
static int index_of(const uint8_t* source, int source_offset, int source_count,