From bf5037d6d54445007a7d9c76975556dfcf4e8afb Mon Sep 17 00:00:00 2001 From: Ashin Gau Date: Tue, 28 Feb 2023 14:29:13 +0800 Subject: [PATCH] [fix](OrcReader) typo in anaylize null values (#17156) typographical error in analyzing null values for OrcReader. --- be/src/vec/exec/format/orc/vorc_reader.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/be/src/vec/exec/format/orc/vorc_reader.cpp b/be/src/vec/exec/format/orc/vorc_reader.cpp index a253a9562a..5ff453df06 100644 --- a/be/src/vec/exec/format/orc/vorc_reader.cpp +++ b/be/src/vec/exec/format/orc/vorc_reader.cpp @@ -674,7 +674,7 @@ Status OrcReader::_decode_string_column(const std::string& col_name, if (type_kind == orc::TypeKind::CHAR) { // Possibly there are some zero padding characters in CHAR type, we have to strip them off. for (int i = 0; i < num_values; ++i) { - if (cvb->notNull[0]) { + if (cvb->notNull[i]) { string_values.emplace_back(data->data[i], trim_right(data->data[i], data->length[i])); } else { @@ -686,7 +686,7 @@ Status OrcReader::_decode_string_column(const std::string& col_name, } } else { for (int i = 0; i < num_values; ++i) { - if (cvb->notNull[0]) { + if (cvb->notNull[i]) { string_values.emplace_back(data->data[i], data->length[i]); } else { string_values.emplace_back(empty_string.data(), 0);