[fix][refactor] fix bugs and refactor some code by lint (#7871)

1. Fix some `passedByValue` issues.
2. Fix some `dereferenceBeforeCheck` issues.
3. Fix some `uninitMemberVar` issues.
4. Fix some iterator `eraseDereference` issues.
5. Fix compile issue introduced from #7923 #7905 #7848

be/src/olap/version_graph.cpp

@@ -280,9 +280,9 @@ void TimestampedVersionTracker::recover_versioned_tracker(
         while (version_path_iter != timestamped_versions.end()) {
             // add version to _version_graph
             _version_graph.add_version_to_graph((*version_path_iter)->version());
-            version_path_iter++;
+            ++version_path_iter;
         }
-        _path_map_iter++;
+        ++_path_map_iter;
     }
     LOG(INFO) << "recover_versioned_tracker current map info " << get_current_path_map_str();
 }
@@ -335,7 +335,7 @@ void TimestampedVersionTracker::capture_expired_paths(
             int64_t path_version = iter->first;
             path_version_vec->push_back(path_version);
         }
-        iter++;
+        ++iter;
     }
 }
 
@@ -388,11 +388,11 @@ std::string TimestampedVersionTracker::get_current_path_map_str() {
             tracker_info << (*version_path_iter)->version().second;
             tracker_info << "]";
 
-            version_path_iter++;
+            ++version_path_iter;
         }
 
         tracker_info << std::endl;
-        iter++;
+        ++iter;
     }
     return tracker_info.str();
 }