From c620e06f6a91a5e33c96759cd11faf404b476345 Mon Sep 17 00:00:00 2001 From: Tiewei Fang <43782773+BePPPower@users.noreply.github.com> Date: Mon, 13 Feb 2023 21:01:53 +0800 Subject: [PATCH] [Enhencement](Broker reader)Use smart Pointer instead of native Pointers in broker reader --- be/src/io/broker_reader.cpp | 3 +-- be/src/io/fs/broker_file_system.cpp | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/be/src/io/broker_reader.cpp b/be/src/io/broker_reader.cpp index 1073fd3ac6..34e25930ea 100644 --- a/be/src/io/broker_reader.cpp +++ b/be/src/io/broker_reader.cpp @@ -77,8 +77,7 @@ Status BrokerReader::open() { request.__set_clientId(client_id(_env, broker_addr)); request.__set_properties(_properties); - TBrokerOpenReaderResponse* response = new TBrokerOpenReaderResponse(); - Defer del_reponse {[&] { delete response; }}; + std::unique_ptr response(new TBrokerOpenReaderResponse()); try { Status status; BrokerServiceConnection client(client_cache(_env), broker_addr, diff --git a/be/src/io/fs/broker_file_system.cpp b/be/src/io/fs/broker_file_system.cpp index 875eb0829b..681fa014d4 100644 --- a/be/src/io/fs/broker_file_system.cpp +++ b/be/src/io/fs/broker_file_system.cpp @@ -94,8 +94,7 @@ Status BrokerFileSystem::open_file(const Path& path, FileReaderSPtr* reader, request.__set_clientId(client_id(_broker_addr)); request.__set_properties(_broker_prop); - TBrokerOpenReaderResponse* response = new TBrokerOpenReaderResponse(); - Defer del_reponse {[&] { delete response; }}; + std::unique_ptr response(new TBrokerOpenReaderResponse()); try { Status status; try {