From c6822f513a92affe8b1d78fd6b389bfa44ebc12e Mon Sep 17 00:00:00 2001 From: sduzh Date: Mon, 4 May 2020 15:26:52 +0800 Subject: [PATCH] [Code refactor] Remove unnecessary if condition (#3459) if _opts.conditions is nullptr, the set cids would be empty. --- be/src/olap/rowset/segment_v2/segment_iterator.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/be/src/olap/rowset/segment_v2/segment_iterator.cpp b/be/src/olap/rowset/segment_v2/segment_iterator.cpp index cbb402488c..50e81d0f90 100644 --- a/be/src/olap/rowset/segment_v2/segment_iterator.cpp +++ b/be/src/olap/rowset/segment_v2/segment_iterator.cpp @@ -239,10 +239,7 @@ Status SegmentIterator::_get_row_ranges_from_conditions(RowRanges* condition_row for (auto& cid : cids) { // get row ranges by bf index of this column, RowRanges column_bf_row_ranges = RowRanges::create_single(num_rows()); - CondColumn* column_cond = nullptr; - if (_opts.conditions != nullptr) { - column_cond = _opts.conditions->get_column(cid); - } + CondColumn* column_cond = _opts.conditions->get_column(cid); RETURN_IF_ERROR( _column_iterators[cid]->get_row_ranges_by_bloom_filter( column_cond,