From c8b0840e6ceb78827d57f1e08d6e7d96f9ec5b7a Mon Sep 17 00:00:00 2001 From: walter Date: Thu, 1 Feb 2024 18:55:12 +0800 Subject: [PATCH] [improve](backup) Skip all backup/restore jobs if max allowd option is set to 0 (#30677) If there are too many backup/restore jobs, it may cause OOM. This PR allows the user to skip all backup/restore jobs if max_backup_restore_job_num_per_db is set to 0. --- .../main/java/org/apache/doris/backup/BackupHandler.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupHandler.java b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupHandler.java index 7c0485228f..a4332e054c 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupHandler.java +++ b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupHandler.java @@ -516,6 +516,12 @@ public class BackupHandler extends MasterDaemon implements Writable { } private void addBackupOrRestoreJob(long dbId, AbstractJob job) { + // If there are too many backup/restore jobs, it may cause OOM. If the job num option is set to 0, + // skip all backup/restore jobs. + if (Config.max_backup_restore_job_num_per_db <= 0) { + return; + } + jobLock.lock(); try { Deque jobs = dbIdToBackupOrRestoreJobs.computeIfAbsent(dbId, k -> Lists.newLinkedList());