From c8ccada010a3cf149e943bdecd21ee7993f336bf Mon Sep 17 00:00:00 2001 From: bobhan1 Date: Tue, 11 Feb 2025 16:56:13 +0800 Subject: [PATCH] =?UTF-8?q?branch-2.1:=20[Fix](memory)=20Add=20try=20catch?= =?UTF-8?q?=20block=20for=20`Segment::load=5Fpk=5Findex=5Fand=5Fbf`?= =?UTF-8?q?=E2=80=A6=20(#47742)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pick https://github.com/apache/doris/pull/47715 --- be/src/olap/rowset/segment_v2/segment.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/be/src/olap/rowset/segment_v2/segment.cpp b/be/src/olap/rowset/segment_v2/segment.cpp index 9126a081d5..1f98eafd6f 100644 --- a/be/src/olap/rowset/segment_v2/segment.cpp +++ b/be/src/olap/rowset/segment_v2/segment.cpp @@ -25,6 +25,7 @@ #include #include +#include "common/exception.h" #include "common/logging.h" #include "common/status.h" #include "io/fs/file_reader.h" @@ -327,8 +328,13 @@ Status Segment::_load_pk_bloom_filter() { } Status Segment::load_pk_index_and_bf() { - RETURN_IF_ERROR(load_index()); - RETURN_IF_ERROR(_load_pk_bloom_filter()); + // `DorisCallOnce` may catch exception in calling stack A and re-throw it in + // a different calling stack B which doesn't have catch block. So we add catch block here + // to prevent coreudmp + RETURN_IF_CATCH_EXCEPTION({ + RETURN_IF_ERROR(load_index()); + RETURN_IF_ERROR(_load_pk_bloom_filter()); + }); return Status::OK(); }