database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](datetime) fix unstable str_to_date function result (#25707)

Browse Source 
fix unstable str_to_date function result
This commit is contained in:
zclllyybb
2023-10-23 11:52:08 +08:00
committed by GitHub
parent 4889841ff7
commit cbc5c91aec
8 changed files with 38 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
be/src/vec/functions/function_timestamp.cpp
View File

@ -64,16 +64,22 @@
namespace doris::vectorized {
template <typename DateType>
struct StrToDate {
static constexpr auto name = "str_to_date";
static bool is_variadic() { return false; }
static DataTypes get_variadic_argument_types() { return {}; }
static DataTypes get_variadic_argument_types() {
return {std::make_shared<DataTypeString>(), std::make_shared<DataTypeString>()};
}
static DataTypePtr get_return_type_impl(const DataTypes& arguments) {
//TODO: it doesn't matter now. maybe sometime we should find the function signature with return_type together
return make_nullable(std::make_shared<DataTypeDateTime>());
if constexpr (IsDateType<DateType> || IsDateV2Type<DateType>) {
return make_nullable(std::make_shared<DataTypeDateV2>());
}
//datetimev2
return make_nullable(std::make_shared<DataTypeDateTimeV2>(6));
}
static StringRef rewrite_specific_format(const char* raw_str, size_t str_size) {
@ -1266,7 +1272,8 @@ public:
}
};
using FunctionStrToDate = FunctionOtherTypesToDateType<StrToDate>;
using FunctionStrToDate = FunctionOtherTypesToDateType<StrToDate<DataTypeDateV2>>;
using FunctionStrToDatetime = FunctionOtherTypesToDateType<StrToDate<DataTypeDateTimeV2>>;
using FunctionMakeDate = FunctionOtherTypesToDateType<MakeDateImpl>;
using FunctionDateTruncDate = FunctionOtherTypesToDateType<DateTrunc<DataTypeDate>>;
using FunctionDateTruncDateV2 = FunctionOtherTypesToDateType<DateTrunc<DataTypeDateV2>>;
@ -1275,6 +1282,7 @@ using FunctionDateTruncDatetimeV2 = FunctionOtherTypesToDateType<DateTrunc<DataT
void register_function_timestamp(SimpleFunctionFactory& factory) {
factory.register_function<FunctionStrToDate>();
factory.register_function<FunctionStrToDatetime>();
factory.register_function<FunctionMakeDate>();
factory.register_function<FromDays>();
factory.register_function<FunctionDateTruncDate>();