From cdba4c4775b0685f37e48045d29928c93f575dbd Mon Sep 17 00:00:00 2001
From: morrySnow <101034200+morrySnow@users.noreply.github.com>
Date: Mon, 9 Oct 2023 14:52:36 +0800
Subject: [PATCH] [fix](Nereids) deep copier generate wrong slot for TVF
 (#25156)

---
 .../doris/nereids/trees/copier/LogicalPlanDeepCopier.java    | 2 +-
 regression-test/data/nereids_p0/with/test_with.out           | 5 +++++
 regression-test/suites/nereids_p0/with/test_with.groovy      | 3 +++
 3 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/LogicalPlanDeepCopier.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/LogicalPlanDeepCopier.java
index b159a3593f..17b2f0d2d3 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/LogicalPlanDeepCopier.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/copier/LogicalPlanDeepCopier.java
@@ -229,7 +229,7 @@ public class LogicalPlanDeepCopier extends DefaultPlanRewriter<DeepCopierContext
         }
         LogicalTVFRelation newTVFRelation = new LogicalTVFRelation(StatementScopeIdGenerator.newRelationId(),
                 tvfRelation.getFunction());
-        updateReplaceMapWithOutput(newTVFRelation, tvfRelation, context.exprIdReplaceMap);
+        updateReplaceMapWithOutput(tvfRelation, newTVFRelation, context.exprIdReplaceMap);
         context.putRelation(tvfRelation.getRelationId(), newTVFRelation);
         return newTVFRelation;
     }
diff --git a/regression-test/data/nereids_p0/with/test_with.out b/regression-test/data/nereids_p0/with/test_with.out
index cd4b476602..d4cf0a1151 100644
--- a/regression-test/data/nereids_p0/with/test_with.out
+++ b/regression-test/data/nereids_p0/with/test_with.out
@@ -30,3 +30,8 @@
 2
 3
 
+-- !tvf_in_cte --
+0
+1
+2
+
diff --git a/regression-test/suites/nereids_p0/with/test_with.groovy b/regression-test/suites/nereids_p0/with/test_with.groovy
index 555662b9e2..39db78a257 100644
--- a/regression-test/suites/nereids_p0/with/test_with.groovy
+++ b/regression-test/suites/nereids_p0/with/test_with.groovy
@@ -48,5 +48,8 @@ suite("test_with") {
                 SELECT * FROM outermost ORDER BY 1;
               """
 
+    order_qt_tvf_in_cte """
+        with a as (select number from numbers("number"="3")) select * from a;
+    """
 
 }