From d0219062ef047c55ca405da25d8f319fcbdf077f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E8=B5=B5=E7=AB=8B=E4=BC=9F?= Date: Mon, 24 Jul 2023 08:51:28 +0800 Subject: [PATCH] [refactor](be) use std::move to improve performance of push_back #22056 --- be/src/exec/olap_common.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/be/src/exec/olap_common.h b/be/src/exec/olap_common.h index 2260dac25c..7a58645b74 100644 --- a/be/src/exec/olap_common.h +++ b/be/src/exec/olap_common.h @@ -207,7 +207,7 @@ public: } if (null_pred.condition_values.size() != 0) { - filters.push_back(null_pred); + filters.push_back(std::move(null_pred)); return; } @@ -221,7 +221,7 @@ public: } if (low.condition_values.size() != 0) { - filters.push_back(low); + filters.push_back(std::move(low)); } TCondition high; @@ -234,7 +234,7 @@ public: } if (high.condition_values.size() != 0) { - filters.push_back(high); + filters.push_back(std::move(high)); } } else { // 3. convert to is null and is not null filter condition @@ -247,7 +247,7 @@ public: } if (null_pred.condition_values.size() != 0) { - filters.push_back(null_pred); + filters.push_back(std::move(null_pred)); } } } @@ -264,7 +264,7 @@ public: } if (condition.condition_values.size() != 0) { - filters.push_back(condition); + filters.push_back(std::move(condition)); } } @@ -288,7 +288,7 @@ public: condition.condition_values.push_back( cast_to_string(value.second, _scale)); if (condition.condition_values.size() != 0) { - filters.push_back(condition); + filters.push_back(std::move(condition)); } } } @@ -318,7 +318,7 @@ public: condition.condition_values.push_back( cast_to_string(value.second, _scale)); if (condition.condition_values.size() != 0) { - filters.push_back(condition); + filters.push_back(std::move(condition)); } } }