database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Fix](executor)Fix scan entity core #21696

Browse Source 
After the last time to call scan_task.scan_func()，the should be ended, this means PipelineFragmentContext could be released.
Then after PipelineFragmentContext is released, visiting its field such as query_ctx or _state may cause core dump.
But it can only explain core 2

void ScannerScheduler::_task_group_scanner_scan(ScannerScheduler* scheduler,
                                                taskgroup::ScanTaskTaskGroupQueue* scan_queue) {
    while (!_is_closed) {
        taskgroup::ScanTask scan_task;
        auto success = scan_queue->take(&scan_task);
        if (success) {
            int64_t time_spent = 0;
            {
                SCOPED_RAW_TIMER(&time_spent);
                scan_task.scan_func();
            }
            scan_queue->update_statistics(scan_task, time_spent);
        }
    }
}
This commit is contained in:
wangbo
2023-07-11 15:56:13 +08:00
committed by GitHub
parent 4cbd99ad9b
commit d3317aa33b
3 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
be/src/vec/exec/scan/scan_task_queue.cpp
View File

@ -24,11 +24,14 @@
namespace doris {
namespace taskgroup {
static void empty_function() {}
ScanTask::ScanTask() : ScanTask(empty_function, nullptr, 1) {}
ScanTask::ScanTask() : ScanTask(empty_function, nullptr, nullptr, 1) {}
ScanTask::ScanTask(WorkFunction scan_func, vectorized::ScannerContext* scanner_context,
int priority)
: scan_func(std::move(scan_func)), scanner_context(scanner_context), priority(priority) {}
TGSTEntityPtr scan_entity, int priority)
: scan_func(std::move(scan_func)),
scanner_context(scanner_context),
scan_entity(scan_entity),
priority(priority) {}
ScanTaskQueue::ScanTaskQueue() : _queue(config::doris_scanner_thread_pool_queue_size) {}
@ -98,7 +101,7 @@ bool ScanTaskTaskGroupQueue::push_back(ScanTask scan_task) {
}
void ScanTaskTaskGroupQueue::update_statistics(ScanTask scan_task, int64_t time_spent) {
auto* entity = scan_task.scanner_context->get_task_group()->local_scan_task_entity();
auto* entity = scan_task.scan_entity;
std::unique_lock<std::mutex> lock(_rs_mutex);
auto find_entity = _group_entities.find(entity);
bool is_in_queue = find_entity != _group_entities.end();