database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Open datetime min value limit (#3158)

Browse Source 
the min_value in olap/type.h of datetime is 0000-01-01 00:00:00, so we don't need restrict datetime min in tablet_sink
This commit is contained in:
HangyuanLiu
2020-03-24 10:52:57 +08:00
committed by GitHub
parent dff3c0d57e
commit d4c1938b5c
15 changed files with 82 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
fe/src/test/java/org/apache/doris/analysis/LiteralExprCompareTest.java
View File

@ -87,8 +87,8 @@ public class LiteralExprCompareTest {
LiteralExpr minDatetime1Same = new DateLiteral(ScalarType.DATETIME, false);
LiteralExpr date8 = new DateLiteral("9999-12-31", ScalarType.DATE);
LiteralExpr date9 = new DateLiteral("9999-12-31 23:59:59", ScalarType.DATETIME);
LiteralExpr date10 = new DateLiteral("1900-01-01", ScalarType.DATE);
LiteralExpr date11 = new DateLiteral("1900-01-01 00:00:00", ScalarType.DATETIME);
LiteralExpr date10 = new DateLiteral("0000-01-01", ScalarType.DATE);
LiteralExpr date11 = new DateLiteral("0000-01-01 00:00:00", ScalarType.DATETIME);
Assert.assertTrue(date1.equals(date1Same) && date1.compareLiteral(date1Same) == 0);
Assert.assertTrue(date1.equals(date1Same) && date1.compareLiteral(date1Same) == 0);

2
fe/src/test/java/org/apache/doris/catalog/PartitionKeyTest.java
View File

@ -134,7 +134,7 @@ public class PartitionKeyTest {
pk1 = PartitionKey.createPartitionKey(Arrays.asList(new PartitionValue("-128"), new PartitionValue("-32768"),
new PartitionValue("-2147483648"), new PartitionValue("-9223372036854775808"),
new PartitionValue("-170141183460469231731687303715884105728"),
new PartitionValue("1900-01-01"), new PartitionValue("1900-01-01 00:00:00")),
new PartitionValue("0000-01-01"), new PartitionValue("0000-01-01 00:00:00")),
allColumns);
pk2 = PartitionKey.createInfinityPartitionKey(allColumns, false);
Assert.assertTrue(pk1.equals(pk2) && pk1.compareTo(pk2) == 0);

6
fe/src/test/java/org/apache/doris/common/util/TimeUtilsTest.java
View File

@ -57,9 +57,9 @@ public class TimeUtilsTest {
Assert.assertNotNull(TimeUtils.getStartTime());
Assert.assertTrue(TimeUtils.getEstimatedTime(0L) > 0);
Assert.assertEquals(-2209017600000L, TimeUtils.MIN_DATE.getTime());
Assert.assertEquals(-62167420800000L, TimeUtils.MIN_DATE.getTime());
Assert.assertEquals(253402185600000L, TimeUtils.MAX_DATE.getTime());
Assert.assertEquals(-2209017600000L, TimeUtils.MIN_DATETIME.getTime());
Assert.assertEquals(-62167420800000L, TimeUtils.MIN_DATETIME.getTime());
Assert.assertEquals(253402271999000L, TimeUtils.MAX_DATETIME.getTime());
}
@ -74,6 +74,7 @@ public class TimeUtilsTest {
validDateList.add("9999-12-31");
validDateList.add("1900-01-01");
validDateList.add("2013-2-28");
validDateList.add("0000-01-01");
for (String validDate : validDateList) {
try {
TimeUtils.parseDate(validDate, PrimitiveType.DATE);
@ -112,6 +113,7 @@ public class TimeUtilsTest {
validDateTimeList.add("2013-2-28 23:59:59");
validDateTimeList.add("2013-2-28 2:3:4");
validDateTimeList.add("2014-05-07 19:8:50");
validDateTimeList.add("0000-01-01 00:00:00");
for (String validDateTime : validDateTimeList) {
try {
TimeUtils.parseDate(validDateTime, PrimitiveType.DATETIME);