database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug](function) fix function in get wrong result when input const column (#19791)

Browse Source 
fix function in get wrong result when input const column
This commit is contained in:
Pxl
2023-05-22 10:58:29 +08:00
committed by GitHub
parent f57b6adba9
commit d64be9565d
66 changed files with 135 additions and 221 deletions
Download Patch File Download Diff File Expand all files Collapse all files

57
be/src/vec/exprs/vexpr.cpp
View File

@ -49,6 +49,7 @@
#include "vec/exprs/vslot_ref.h"
#include "vec/exprs/vstruct_literal.h"
#include "vec/exprs/vtuple_is_null_predicate.h"
#include "vec/utils/util.hpp"
namespace doris {
class RowDescriptor;
@ -61,7 +62,7 @@ using doris::RuntimeState;
using doris::RowDescriptor;
using doris::TypeDescriptor;
VExpr::VExpr(const doris::TExprNode& node)
VExpr::VExpr(const TExprNode& node)
: _node_type(node.node_type),
_opcode(node.__isset.opcode ? node.opcode : TExprOpcode::INVALID_OPCODE),
_type(TypeDescriptor::from_thrift(node.type)),
@ -119,14 +120,14 @@ Status VExpr::open(RuntimeState* state, VExprContext* context,
return Status::OK();
}
void VExpr::close(doris::RuntimeState* state, VExprContext* context,
void VExpr::close(RuntimeState* state, VExprContext* context,
FunctionContext::FunctionStateScope scope) {
for (int i = 0; i < _children.size(); ++i) {
_children[i]->close(state, context, scope);
}
}
Status VExpr::create_expr(ObjectPool* pool, const doris::TExprNode& texpr_node, VExpr** expr) {
Status VExpr::create_expr(ObjectPool* pool, const TExprNode& texpr_node, VExpr** expr) {
try {
switch (texpr_node.node_type) {
case TExprNodeType::BOOL_LITERAL:
@ -153,43 +154,43 @@ Status VExpr::create_expr(ObjectPool* pool, const doris::TExprNode& texpr_node,
*expr = pool->add(VStructLiteral::create_unique(texpr_node).release());
break;
}
case doris::TExprNodeType::SLOT_REF: {
case TExprNodeType::SLOT_REF: {
*expr = pool->add(VSlotRef::create_unique(texpr_node).release());
break;
}
case doris::TExprNodeType::COLUMN_REF: {
case TExprNodeType::COLUMN_REF: {
*expr = pool->add(VColumnRef::create_unique(texpr_node).release());
break;
}
case doris::TExprNodeType::COMPOUND_PRED: {
case TExprNodeType::COMPOUND_PRED: {
*expr = pool->add(VcompoundPred::create_unique(texpr_node).release());
break;
}
case doris::TExprNodeType::LAMBDA_FUNCTION_EXPR: {
case TExprNodeType::LAMBDA_FUNCTION_EXPR: {
*expr = pool->add(VLambdaFunctionExpr::create_unique(texpr_node).release());
break;
}
case doris::TExprNodeType::LAMBDA_FUNCTION_CALL_EXPR: {
case TExprNodeType::LAMBDA_FUNCTION_CALL_EXPR: {
*expr = pool->add(VLambdaFunctionCallExpr::create_unique(texpr_node).release());
break;
}
case doris::TExprNodeType::ARITHMETIC_EXPR:
case doris::TExprNodeType::BINARY_PRED:
case doris::TExprNodeType::FUNCTION_CALL:
case doris::TExprNodeType::COMPUTE_FUNCTION_CALL:
case doris::TExprNodeType::MATCH_PRED: {
case TExprNodeType::ARITHMETIC_EXPR:
case TExprNodeType::BINARY_PRED:
case TExprNodeType::FUNCTION_CALL:
case TExprNodeType::COMPUTE_FUNCTION_CALL:
case TExprNodeType::MATCH_PRED: {
*expr = pool->add(VectorizedFnCall::create_unique(texpr_node).release());
break;
}
case doris::TExprNodeType::CAST_EXPR: {
case TExprNodeType::CAST_EXPR: {
*expr = pool->add(VCastExpr::create_unique(texpr_node).release());
break;
}
case doris::TExprNodeType::IN_PRED: {
case TExprNodeType::IN_PRED: {
*expr = pool->add(VInPredicate::create_unique(texpr_node).release());
break;
}
case doris::TExprNodeType::CASE_EXPR: {
case TExprNodeType::CASE_EXPR: {
if (!texpr_node.__isset.case_expr) {
return Status::InternalError("Case expression not set in thrift node");
}
@ -211,7 +212,7 @@ Status VExpr::create_expr(ObjectPool* pool, const doris::TExprNode& texpr_node,
default:
return Status::InternalError("Unknown expr node type: {}", texpr_node.node_type);
}
} catch (const doris::Exception& e) {
} catch (const Exception& e) {
return Status::Error(e.code(), e.to_string());
}
if (!(*expr)->data_type()) {
@ -220,9 +221,8 @@ Status VExpr::create_expr(ObjectPool* pool, const doris::TExprNode& texpr_node,
return Status::OK();
}
Status VExpr::create_tree_from_thrift(doris::ObjectPool* pool,
const std::vector<doris::TExprNode>& nodes, int* node_idx,
VExpr** root_expr, VExprContext** ctx) {
Status VExpr::create_tree_from_thrift(ObjectPool* pool, const std::vector<TExprNode>& nodes,
int* node_idx, VExpr** root_expr, VExprContext** ctx) {
// propagate error case
if (*node_idx >= nodes.size()) {
return Status::InternalError("Failed to reconstruct expression tree from thrift.");
@ -237,9 +237,9 @@ Status VExpr::create_tree_from_thrift(doris::ObjectPool* pool,
DCHECK(root_expr != nullptr);
DCHECK(ctx != nullptr);
*root_expr = root;
*ctx = pool->add(VExprContext::create_unique(root).release());
// short path for leaf node
if (root_children <= 0) {
*ctx = pool->add(VExprContext::create_unique(root).release());
return Status::OK();
}
@ -266,11 +266,11 @@ Status VExpr::create_tree_from_thrift(doris::ObjectPool* pool,
s.push({expr, num_children});
}
}
*ctx = pool->add(VExprContext::create_unique(root).release());
return Status::OK();
}
Status VExpr::create_expr_tree(doris::ObjectPool* pool, const doris::TExpr& texpr,
VExprContext** ctx) {
Status VExpr::create_expr_tree(ObjectPool* pool, const TExpr& texpr, VExprContext** ctx) {
if (texpr.nodes.size() == 0) {
*ctx = nullptr;
return Status::OK();
@ -291,7 +291,7 @@ Status VExpr::create_expr_tree(doris::ObjectPool* pool, const doris::TExpr& texp
return status;
}
Status VExpr::create_expr_trees(ObjectPool* pool, const std::vector<doris::TExpr>& texprs,
Status VExpr::create_expr_trees(ObjectPool* pool, const std::vector<TExpr>& texprs,
std::vector<VExprContext*>* ctxs) {
ctxs->clear();
for (int i = 0; i < texprs.size(); ++i) {
@ -407,7 +407,7 @@ Status VExpr::get_const_col(VExprContext* context,
return Status::OK();
}
void VExpr::register_function_context(doris::RuntimeState* state, VExprContext* context) {
void VExpr::register_function_context(RuntimeState* state, VExprContext* context) {
std::vector<TypeDescriptor> arg_types;
for (int i = 0; i < _children.size(); ++i) {
arg_types.push_back(_children[i]->type());
@ -448,4 +448,11 @@ void VExpr::close_function_context(VExprContext* context, FunctionContext::Funct
}
}
Status VExpr::check_constant(const Block& block, ColumnNumbers arguments) const {
if (is_constant() && !VectorizedUtils::all_arguments_are_constant(block, arguments)) {
return Status::InternalError("const check failed, expr={}", debug_string());
}
return Status::OK();
}
} // namespace doris::vectorized