database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](planner)should always use plan node's getTblRefIds method to get unassigned conjuncts for this node (#25130)

Browse Source
This commit is contained in:
starocean999
2023-10-11 16:34:21 +08:00
committed by GitHub
parent 2221c8e2ed
commit dabeeb0338
3 changed files with 40 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java
View File

@ -41,6 +41,7 @@ import org.apache.doris.common.IdGenerator;
import org.apache.doris.common.Pair;
import org.apache.doris.common.util.TimeUtils;
import org.apache.doris.planner.AggregationNode;
import org.apache.doris.planner.AnalyticEvalNode;
import org.apache.doris.planner.PlanNode;
import org.apache.doris.planner.RuntimeFilter;
import org.apache.doris.qe.ConnectContext;
@ -2457,12 +2458,12 @@ public class Analyzer {
* Wrapper around getUnassignedConjuncts(List<TupleId> tupleIds).
*/
public List<Expr> getUnassignedConjuncts(PlanNode node) {
// constant conjuncts should be push down to all leaf node except agg node.
// constant conjuncts should be push down to all leaf node except agg and analytic node.
// (see getPredicatesBoundedByGroupbysSourceExpr method)
// so we need remove constant conjuncts when expr is not a leaf node.
List<Expr> unassigned = getUnassignedConjuncts(
node instanceof AggregationNode ? node.getTupleIds() : node.getTblRefIds());
if (!node.getChildren().isEmpty() && !(node instanceof AggregationNode)) {
List<Expr> unassigned = getUnassignedConjuncts(node.getTblRefIds());
if (!node.getChildren().isEmpty()
&& !(node instanceof AggregationNode || node instanceof AnalyticEvalNode)) {
unassigned = unassigned.stream()
.filter(e -> !e.isConstant()).collect(Collectors.toList());
}