From db7eaad3cf0447bd03d152ed33cc716c141d24c1 Mon Sep 17 00:00:00 2001 From: Calvin Kirs Date: Wed, 28 Jun 2023 00:18:25 +0800 Subject: [PATCH] [Fix](CI)After Approve, even comments should be considered as mergeable (#21264) --- .github/workflows/pr-approve-status.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/pr-approve-status.yml b/.github/workflows/pr-approve-status.yml index 2a6a64355d..cda6abc8f1 100644 --- a/.github/workflows/pr-approve-status.yml +++ b/.github/workflows/pr-approve-status.yml @@ -43,9 +43,7 @@ jobs: approves=() reviewers_unique=() for ((i=${#reviewers[@]}-1;i>=0;i--)); do - # shellcheck disable=SC2076 - # shellcheck disable=SC2199 - if [[ ! "${reviewers_unique[@]}" =~ "${reviewers[$i]}" ]]; then + if ! echo "${reviewers_unique[@]}" | grep -q -w "${reviewers[$i]}" && [ "${statuses[$i]}" != "COMMENTED" ]; then reviewers_unique+=( "${reviewers[$i]}" ) if [ "${statuses[$i]}" == "APPROVED" ]; then approves+=( "${reviewers[$i]}" )