database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

Make StringValue's memory layout same with Slice (#1712)

Browse Source 
In our storage engine's code, we cast StringValue to Slice. Because
their memory layout is different, it may cause BE process crash.

We make their memory layout same in this patch to resolve this problem
temporary. We should improve it some day.
This commit is contained in:
ZHAO Chun
2019-08-27 22:15:46 +08:00
committed by Mingyu Chen
parent 34a6e06cb1
commit dc2d49fe07
4 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
be/src/runtime/string_value.h
View File

@ -33,8 +33,11 @@ struct StringValue {
// TODO: change ptr to an offset relative to a contiguous memory block,
// so that we can send row batches between nodes without having to swizzle
// pointers
// NOTE: This struct should keep the same memory layout with Slice, otherwise
// it will lead to BE crash.
// TODO(zc): we should unify this struct with Slice some day.
char* ptr;
int len;
size_t len;
StringValue(char* ptr, int len): ptr(ptr), len(len) {}
StringValue(): ptr(NULL), len(0) {}