From dda505487c68f709e8f334a2cd1a19de08571df6 Mon Sep 17 00:00:00 2001 From: minghong Date: Thu, 29 Dec 2022 22:53:27 +0800 Subject: [PATCH] [fix](nereids) SimplifyArithmeticRuleTest ut failed (#15486) this PR remove typeCoercion on expected expr in ExpressionRewriteTestHelper. Because we should not rewrite expected expr at all. It will change the expected expr unexpectedly. --- .../rules/expression/rewrite/ExpressionRewriteTestHelper.java | 1 - 1 file changed, 1 deletion(-) diff --git a/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionRewriteTestHelper.java b/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionRewriteTestHelper.java index f4aabee6f4..75824b2441 100644 --- a/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionRewriteTestHelper.java +++ b/fe/fe-core/src/test/java/org/apache/doris/nereids/rules/expression/rewrite/ExpressionRewriteTestHelper.java @@ -66,7 +66,6 @@ public abstract class ExpressionRewriteTestHelper { Expression needRewriteExpression = PARSER.parseExpression(expression); needRewriteExpression = typeCoercion(replaceUnboundSlot(needRewriteExpression, mem)); Expression expectedExpression = PARSER.parseExpression(expected); - expectedExpression = typeCoercion(replaceUnboundSlot(expectedExpression, mem)); Expression rewrittenExpression = executor.rewrite(needRewriteExpression); Assertions.assertEquals(expectedExpression.toSql(), rewrittenExpression.toSql()); }