From df628e153804ec8102c20bfda02639ee80941601 Mon Sep 17 00:00:00 2001 From: Xin Liao Date: Thu, 23 Nov 2023 23:39:01 +0800 Subject: [PATCH] [chore](merge-on-write) disable rowid conversion check for mow table by default (#27482) --- be/src/common/config.cpp | 2 ++ be/src/common/config.h | 2 ++ be/src/olap/compaction.cpp | 8 ++++++-- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp index adbc61fe56..b8ad3523b3 100644 --- a/be/src/common/config.cpp +++ b/be/src/common/config.cpp @@ -1068,6 +1068,8 @@ DEFINE_mInt64(lookup_connection_cache_bytes_limit, "4294967296"); DEFINE_mInt64(LZ4_HC_compression_level, "9"); DEFINE_mBool(enable_merge_on_write_correctness_check, "true"); +// rowid conversion correctness check when compaction for mow table +DEFINE_mBool(enable_rowid_conversion_correctness_check, "false"); // The secure path with user files, used in the `local` table function. DEFINE_mString(user_files_secure_path, "${DORIS_HOME}"); diff --git a/be/src/common/config.h b/be/src/common/config.h index f616cfb608..f080063265 100644 --- a/be/src/common/config.h +++ b/be/src/common/config.h @@ -1130,6 +1130,8 @@ DECLARE_mBool(enable_flatten_nested_for_variant); DECLARE_mDouble(ratio_of_defaults_as_sparse_column); DECLARE_mBool(enable_merge_on_write_correctness_check); +// rowid conversion correctness check when compaction for mow table +DECLARE_mBool(enable_rowid_conversion_correctness_check); // The secure path with user files, used in the `local` table function. DECLARE_mString(user_files_secure_path); diff --git a/be/src/olap/compaction.cpp b/be/src/olap/compaction.cpp index c8d0b2a29f..b57e6dcdc5 100644 --- a/be/src/olap/compaction.cpp +++ b/be/src/olap/compaction.cpp @@ -689,7 +689,9 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) { } } - RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map)); + if (config::enable_rowid_conversion_correctness_check) { + RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map)); + } location_map.clear(); { @@ -750,7 +752,9 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) { } } - RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map)); + if (config::enable_rowid_conversion_correctness_check) { + RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map)); + } _tablet->merge_delete_bitmap(output_rowset_delete_bitmap); RETURN_IF_ERROR(_tablet->modify_rowsets(output_rowsets, _input_rowsets, true));