From e2ea54c0a759c5ee1205d2f66ae76a0e5797d84a Mon Sep 17 00:00:00 2001 From: Pxl Date: Thu, 9 May 2024 20:53:58 +0800 Subject: [PATCH] [Improvement](sink) remove unused check on string's write_column_to_mysql (#34491) remove unused check on string's write_column_to_mysql --- be/src/vec/columns/column_string.h | 2 +- .../data_types/serde/data_type_string_serde.h | 18 +----------------- 2 files changed, 2 insertions(+), 18 deletions(-) diff --git a/be/src/vec/columns/column_string.h b/be/src/vec/columns/column_string.h index 8aa531e466..81a6a469b5 100644 --- a/be/src/vec/columns/column_string.h +++ b/be/src/vec/columns/column_string.h @@ -133,7 +133,7 @@ public: } StringRef get_data_at(size_t n) const override { - assert(n < size()); + DCHECK_LT(n, size()); return StringRef(&chars[offset_at(n)], size_at(n)); } diff --git a/be/src/vec/data_types/serde/data_type_string_serde.h b/be/src/vec/data_types/serde/data_type_string_serde.h index f5d3e47ba1..b870b61d64 100644 --- a/be/src/vec/data_types/serde/data_type_string_serde.h +++ b/be/src/vec/data_types/serde/data_type_string_serde.h @@ -255,23 +255,7 @@ private: int row_idx, bool col_const) const { const auto col_index = index_check_const(row_idx, col_const); const auto string_val = assert_cast(column).get_data_at(col_index); - if (string_val.data == nullptr) { - if (string_val.size == 0) { - // 0x01 is a magic num, not useful actually, just for present "" - char* tmp_val = reinterpret_cast(0x01); - if (UNLIKELY(0 != result.push_string(tmp_val, string_val.size))) { - return Status::InternalError("pack mysql buffer failed."); - } - } else { - if (UNLIKELY(0 != result.push_null())) { - return Status::InternalError("pack mysql buffer failed."); - } - } - } else { - if (UNLIKELY(0 != result.push_string(string_val.data, string_val.size))) { - return Status::InternalError("pack mysql buffer failed."); - } - } + result.push_string(string_val.data, string_val.size); return Status::OK(); } };