[Improvement](join) remove insert_indices_from_join and special judge for -1 (#27779)

remove insert_indices_from_join and special judge for -1
This commit is contained in:
Pxl
2023-12-04 11:03:22 +08:00
committed by GitHub
parent f8bdbf67b4
commit e3d2425d47
45 changed files with 106 additions and 333 deletions

View File

@ -185,25 +185,10 @@ void ColumnMap::insert_from(const IColumn& src_, size_t n) {
get_offsets().push_back(get_offsets().back() + size);
}
void ColumnMap::insert_indices_from(const IColumn& src, const int* indices_begin,
const int* indices_end) {
for (auto x = indices_begin; x != indices_end; ++x) {
if (*x == -1) {
ColumnMap::insert_default();
} else {
ColumnMap::insert_from(src, *x);
}
}
}
void ColumnMap::insert_indices_from_join(const IColumn& src, const uint32_t* indices_begin,
const uint32_t* indices_end) {
for (auto x = indices_begin; x != indices_end; ++x) {
if (*x == 0) {
ColumnMap::insert_default();
} else {
ColumnMap::insert_from(src, *x);
}
void ColumnMap::insert_indices_from(const IColumn& src, const uint32_t* indices_begin,
const uint32_t* indices_end) {
for (const auto* x = indices_begin; x != indices_end; ++x) {
ColumnMap::insert_from(src, *x);
}
}