database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[Bug](materialized-view) fix isDisableTuplesMVRewriter rreturn true when expr is literal (#18246)

Browse Source 
fix isDisableTuplesMVRewriter rreturn true when expr is literal
This commit is contained in:
Pxl
2023-03-31 11:30:47 +08:00
committed by GitHub
parent 8e15388074
commit e7bcd970f5
5 changed files with 51 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
fe/fe-core/src/main/java/org/apache/doris/analysis/Expr.java
View File

@ -2201,6 +2201,12 @@ public abstract class Expr extends TreeNode<Expr> implements ParseNode, Cloneabl
public boolean matchExprs(List<Expr> exprs, SelectStmt stmt, boolean ignoreAlias, String tableName)
throws AnalysisException {
List<SlotRef> slots = new ArrayList<>();
collect(SlotRef.class, slots);
if (slots.size() == 0) {
return true;
}
String name = MaterializedIndexMeta.normalizeName(toSqlWithoutTbl());
for (Expr expr : exprs) {
if (CreateMaterializedViewStmt.isMVColumnNormal(name)

3
fe/fe-core/src/main/java/org/apache/doris/analysis/QueryStmt.java
View File

@ -272,6 +272,9 @@ public abstract class QueryStmt extends StatementBase implements Queriable {
}
public boolean isDisableTuplesMVRewriter(Expr expr) {
if (disableTuplesMVRewriter.isEmpty()) {
return false;
}
return expr.isBoundByTupleIds(disableTuplesMVRewriter.stream().collect(Collectors.toList()));
}

4
fe/fe-core/src/main/java/org/apache/doris/planner/SingleNodePlanner.java
View File

@ -1327,6 +1327,7 @@ public class SingleNodePlanner {
String errorMsg = "select fail reason: ";
if (queryStmt instanceof SelectStmt) {
SelectStmt selectStmt = (SelectStmt) queryStmt;
Set<TupleId> disableTuplesMVRewriter = Sets.newHashSet();
for (TableRef tableRef : selectStmt.getTableRefs()) {
if (tableRef instanceof InlineViewRef) {
selectFailed |= selectMaterializedView(((InlineViewRef) tableRef).getViewStmt(),
@ -1386,9 +1387,10 @@ public class SingleNodePlanner {
}
if (tupleSelectFailed) {
selectFailed = true;
selectStmt.updateDisableTuplesMVRewriter(olapScanNode.getTupleId());
disableTuplesMVRewriter.add(olapScanNode.getTupleId());
}
}
selectStmt.updateDisableTuplesMVRewriter(disableTuplesMVRewriter);
} else {
Preconditions.checkState(queryStmt instanceof SetOperationStmt);
SetOperationStmt unionStmt = (SetOperationStmt) queryStmt;