database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[fix](mtmv)fix thread local reference to checkpoint's Env, causing Env to be unable to be reclaimed, resulting in excessive memory usage by FE (#28723)

Browse Source 
when replay addTaskResult log,will create one ConnectContext,and set Env.getCurrentEnv,then store this ctx in ConnectContext.threadLocalInfo,threadLocalInfo is static,so this ctx can not be recycling，Env of replay thread also can not be recycling
This commit is contained in:
zhangdong
2023-12-20 19:46:58 +08:00
committed by GitHub
parent 7b96730e87
commit ea646c6682
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
fe/fe-core/src/main/java/org/apache/doris/catalog/MTMV.java
View File

@ -153,11 +153,13 @@ public class MTMV extends OlapTable {
this.status.setSchemaChangeDetail(null);
this.status.setRefreshState(MTMVRefreshState.SUCCESS);
this.relation = relation;
try {
this.cache = MTMVCache.from(this, MTMVPlanUtil.createMTMVContext(this));
} catch (Throwable e) {
this.cache = null;
LOG.warn("generate cache failed", e);
if (!Env.isCheckpointThread()) {
try {
this.cache = MTMVCache.from(this, MTMVPlanUtil.createMTMVContext(this));
} catch (Throwable e) {
this.cache = null;
LOG.warn("generate cache failed", e);
}
}
} else {
this.status.setRefreshState(MTMVRefreshState.FAIL);