From ee260d5721320d3cc8bb6731cf2ea1d75300679a Mon Sep 17 00:00:00 2001 From: Mingyu Chen Date: Mon, 1 Jun 2020 21:03:21 +0800 Subject: [PATCH] [Bug][FsBroker] NPE throw when username is empty (#3731) When using Broker with an empty username, a NPE is thrown, which is not expected. --- .../java/org/apache/doris/broker/hdfs/FileSystemManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java b/fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java index 1d377b1c41..076c09cd3c 100644 --- a/fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java +++ b/fs_brokers/apache_hdfs_broker/src/main/java/org/apache/doris/broker/hdfs/FileSystemManager.java @@ -335,7 +335,7 @@ public class FileSystemManager { conf.set(FS_HDFS_IMPL_DISABLE_CACHE, "true"); FileSystem dfsFileSystem = null; if (authentication.equals(AUTHENTICATION_SIMPLE) && - properties.containsKey(USER_NAME_KEY)) { + properties.containsKey(USER_NAME_KEY) && !Strings.isNullOrEmpty(username)) { // Use the specified 'username' as the login name UserGroupInformation ugi = UserGroupInformation.createRemoteUser(username); dfsFileSystem = ugi.doAs(new PrivilegedExceptionAction() {