From f1ede2aa9dfd44f47c3312013e724ae757d49678 Mon Sep 17 00:00:00 2001
From: yinzhijian <373141588@qq.com>
Date: Fri, 19 Aug 2022 09:13:29 +0800
Subject: [PATCH] [fix](function) Fix semantic analysis error in window
 function at first_value (#11855)

---
 .../apache/doris/analysis/AnalyticExpr.java   |  4 +-
 .../test_first_value_window.out               |  8 +++
 .../test_first_value_window.groovy            | 51 +++++++++++++++++++
 3 files changed, 62 insertions(+), 1 deletion(-)
 create mode 100644 regression-test/data/correctness_p0/test_first_value_window.out
 create mode 100644 regression-test/suites/correctness_p0/test_first_value_window.groovy

diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java
index a241da5db3..74ff1d809a 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/AnalyticExpr.java
@@ -747,7 +747,9 @@ public class AnalyticExpr extends Expr {
                 && window != null
                 && window.getLeftBoundary().getType() != BoundaryType.UNBOUNDED_PRECEDING) {
             if (window.getLeftBoundary().getType() != BoundaryType.PRECEDING) {
-                window = new AnalyticWindow(window.getType(), window.getLeftBoundary(),
+                // Here left bound can only be CURRENT_ROW and the function is last_value,
+                // so the type is changed to rows
+                window = new AnalyticWindow(AnalyticWindow.Type.ROWS, window.getLeftBoundary(),
                                             window.getLeftBoundary());
                 fnCall = new FunctionCallExpr(new FunctionName(LASTVALUE),
                                               getFnCall().getParams());
diff --git a/regression-test/data/correctness_p0/test_first_value_window.out b/regression-test/data/correctness_p0/test_first_value_window.out
new file mode 100644
index 0000000000..5a2ad3022b
--- /dev/null
+++ b/regression-test/data/correctness_p0/test_first_value_window.out
@@ -0,0 +1,8 @@
+-- This file is automatically generated. You should know what you did if you want to edit this
+-- !select_default --
+21	04-21-11	1	1
+22	04-22-10-21	0	0
+22	04-22-10-21	1	1
+23	04-23-10	1	1
+24	02-24-10-21	1	1
+
diff --git a/regression-test/suites/correctness_p0/test_first_value_window.groovy b/regression-test/suites/correctness_p0/test_first_value_window.groovy
new file mode 100644
index 0000000000..2819f79277
--- /dev/null
+++ b/regression-test/suites/correctness_p0/test_first_value_window.groovy
@@ -0,0 +1,51 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+suite("test_first_value_window") {
+    def tableName = "state"
+
+
+    sql """ DROP TABLE IF EXISTS ${tableName} """
+    sql """
+            CREATE TABLE ${tableName} (
+            `myday` INT,
+            `time_col` VARCHAR(40) NOT NULL,
+            `state` INT
+            ) ENGINE=OLAP
+            DUPLICATE KEY(`myday`,time_col,state)
+            COMMENT "OLAP"
+            DISTRIBUTED BY HASH(`myday`) BUCKETS 2
+            PROPERTIES (
+            "replication_num" = "1",
+            "in_memory" = "false",
+            "storage_format" = "V2"
+            );
+    """
+
+    sql """ INSERT INTO ${tableName} VALUES 
+            (21,"04-21-11",1),
+            (22,"04-22-10-21",0),
+            (22,"04-22-10-21",1),
+            (23,"04-23-10",1),
+            (24,"02-24-10-21",1); """
+
+    // not_vectorized
+    sql """ set enable_vectorized_engine = false; """
+
+    qt_select_default """ select *,first_value(state) over(partition by myday order by time_col range between current row and unbounded following) from ${tableName} order by myday, time_col, state; """
+
+}