From f412aec1870b513b82d6e1815af97fbf3ecd597b Mon Sep 17 00:00:00 2001
From: chenlinzhong <490103404@qq.com>
Date: Thu, 18 May 2023 11:25:39 +0800
Subject: [PATCH] [improvement](load)disable  shrink memory by default (#19714)

disable shrink memory by default, it becomes very slow when importing large amounts of data
you can turn on If you think it's necessary
---
 be/src/common/config.cpp     | 3 +++
 be/src/common/config.h       | 3 +++
 be/src/olap/delta_writer.cpp | 2 +-
 3 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/be/src/common/config.cpp b/be/src/common/config.cpp
index 22418cbdf0..b0e06a5f26 100644
--- a/be/src/common/config.cpp
+++ b/be/src/common/config.cpp
@@ -993,6 +993,9 @@ DEFINE_mInt32(s3_write_buffer_size, "5242880");
 // s3_write_buffer_whole_size / s3_write_buffer_size
 DEFINE_mInt32(s3_write_buffer_whole_size, "524288000");
 
+//disable shrink memory by default
+DEFINE_Bool(enable_shrink_memory, "false");
+
 #ifdef BE_TEST
 // test s3
 DEFINE_String(test_s3_resource, "resource");
diff --git a/be/src/common/config.h b/be/src/common/config.h
index 2dee7cc20b..8452e73113 100644
--- a/be/src/common/config.h
+++ b/be/src/common/config.h
@@ -1008,6 +1008,9 @@ DECLARE_mInt32(s3_write_buffer_size);
 // s3_write_buffer_whole_size / s3_write_buffer_size
 DECLARE_mInt32(s3_write_buffer_whole_size);
 
+//enable shrink memory
+DECLARE_Bool(enable_shrink_memory);
+
 #ifdef BE_TEST
 // test s3
 DECLARE_String(test_s3_resource);
diff --git a/be/src/olap/delta_writer.cpp b/be/src/olap/delta_writer.cpp
index 9f0c511ae4..48146b90cd 100644
--- a/be/src/olap/delta_writer.cpp
+++ b/be/src/olap/delta_writer.cpp
@@ -225,7 +225,7 @@ Status DeltaWriter::write(const vectorized::Block* block, const std::vector<int>
     }
     _mem_table->insert(block, row_idxs, is_append);
 
-    if (UNLIKELY(_mem_table->need_agg())) {
+    if (UNLIKELY(_mem_table->need_agg() && config::enable_shrink_memory)) {
         _mem_table->shrink_memtable_by_agg();
     }
     if (UNLIKELY(_mem_table->need_flush())) {