database/doris
2
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity

[refactor] remove types_test (#8289)

Browse Source 
* [refactor] remove types_test
1. remove types_test, it will cause core dump in higher version GCC or
   clang, because of memory align, some code will be vectorized in higher
   GCC or clang
2. Change string type length to 2 GB instead of -1
3. modify inaccessible code
This commit is contained in:
Zhengguo Yang
2022-03-03 09:31:35 +08:00
committed by GitHub
parent 8be71b69d5
commit f622ce0497
4 changed files with 8 additions and 65 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
fe/fe-core/src/main/java/org/apache/doris/catalog/ScalarType.java
View File

@ -57,9 +57,6 @@ public class ScalarType extends Type {
// Longest supported VARCHAR and CHAR, chosen to match Hive.
public static final int MAX_VARCHAR_LENGTH = 65533;
// 2GB - 4 4bytes for storage string length
public static final int MAX_STRING_LENGTH = 2147483643;
public static final int MAX_CHAR_LENGTH = 255;
// HLL DEFAULT LENGTH 2^14(registers) + 1(type)
@ -69,6 +66,11 @@ public class ScalarType extends Type {
// Keep consistent with backend ColumnType::CHAR_INLINE_LENGTH
public static final int CHAR_INLINE_LENGTH = 128;
// Max length of String types, in be storage layer store string length
// using int32, the max length is 2GB, the first 4 bytes store the length
// so the max available length is 2GB - 4
public static final int MAX_STRING_LENGTH = 0x7fffffff - 4;
// Hive, mysql, sql server standard.
public static final int MAX_PRECISION = 38;
@ -291,7 +293,7 @@ public class ScalarType extends Type {
public static ScalarType createStringType() {
// length checked in analysis
ScalarType type = new ScalarType(PrimitiveType.STRING);
type.len = -1;
type.len = MAX_STRING_LENGTH;
return type;
}

4
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java
View File

@ -331,8 +331,8 @@ public class ConnectProcessor {
MysqlCommand command = MysqlCommand.fromCode(code);
if (command == null) {
ErrorReport.report(ErrorCode.ERR_UNKNOWN_COM_ERROR);
ctx.getState().setError(ErrorCode.ERR_UNKNOWN_COM_ERROR, "Unknown command(" + command + ")");
LOG.warn("Unknown command(" + command + ")");
ctx.getState().setError(ErrorCode.ERR_UNKNOWN_COM_ERROR, "Unknown command(" + code + ")");
LOG.warn("Unknown command(" + code + ")");
return;
}
ctx.setCommand(command);