From fa8c3aec07ebc481638e2ae6fc09d20e5a49e8e8 Mon Sep 17 00:00:00 2001 From: Mingyu Chen Date: Mon, 13 Nov 2023 09:39:29 +0800 Subject: [PATCH] [opt](load) catch Throwable to make load error msg more clear (#26821) When doing LoadPendingTask or LoadLoadingTask, there may be some Error thrown, such as `NoClassDefFoundError`, but previously, we only catch java's `Exception`, so other kind of error can not be shown clearly. --- .../main/java/org/apache/doris/load/loadv2/LoadTask.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadTask.java b/fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadTask.java index dbedb9facc..d6789805e6 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadTask.java +++ b/fe/fe-core/src/main/java/org/apache/doris/load/loadv2/LoadTask.java @@ -91,10 +91,10 @@ public abstract class LoadTask extends MasterTask { failMsg.setMsg(e.getMessage() == null ? "" : e.getMessage()); LOG.warn(new LogBuilder(LogKey.LOAD_JOB, callback.getCallbackId()) .add("error_msg", "Failed to execute load task").build(), e); - } catch (Exception e) { - failMsg.setMsg(e.getMessage() == null ? "" : e.getMessage()); + } catch (Throwable t) { + failMsg.setMsg(t.getMessage() == null ? "" : t.getMessage()); LOG.warn(new LogBuilder(LogKey.LOAD_JOB, callback.getCallbackId()) - .add("error_msg", "Unexpected failed to execute load task").build(), e); + .add("error_msg", "Unexpected failed to execute load task").build(), t); } finally { if (!isFinished) { // callback on pending task failed