e795c7d2cc
[Community] Add new template for issues ( #6534 )
...
* [Community] Add new template for issues
Inpired by Apache Skywalking
https://github.com/apache/skywalking/issues/new?assignees=&labels=bug&template=bug-report.yml&title=%5BBug%5D+
2021-09-01 09:59:44 +08:00
8d1c1ef1e6
[Community] Fix PR labeling github action workflow ( #6279 )
...
My change is the fix and improvement for github action which labels approved PRs (introduced in this [PR](https://github.com/apache/incubator-doris/pull/6239 )).
It is inspired by solution introduced and tested in [Apache Airflow](https://github.com/apache/airflow ) (thanks @potiuk @ashb 🚀 )
Corresponding Apache Airflow workflows on which I based this PR:
- https://github.com/apache/airflow/blob/main/.github/workflows/label_when_reviewed.yml
- https://github.com/apache/airflow/blob/main/.github/workflows/label_when_reviewed_workflow_run.yml
Problems which were solved in this PR:
- **Permissions**.
@morningman opened a related bug: [[Help] Error: Resource not accessible by integration](https://github.com/TobKed/label-when-approved-action/issues/7 ). It is related to limited permissions of workflows being triggered by `pull_request_review` (`GITHUB_TOKEN` has read-only permissions). More information about it you can find in the article: [Keeping your GitHub Actions and workflows secure: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ ).
TL;DR: On pull request review event (`on: pull_request_review` ) "dummy" workflow `Label when reviewed` triggers another workflow `Label when approved workflow run` which has sufficient permissions (`on: workflow_run: workflows: ["Label when reviewed"]`).
- **Safe use of 3rd-party Github Actions by using submodules pattern.** It is decribed in:
https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status
> NEVER use 3rd-party actions directly in your workflows - use the "submodule" pattern.
This pattern is successfully used by projects like:
- [Apache Airflow](https://github.com/apache/airflow ) ([PR](https://github.com/apache/airflow/pull/13514# ))
- [Apache Beam](https://github.com/apache/beam ) ([PR](https://github.com/apache/beam/pull/13736 ))
- [Apache Superset](https://github.com/apache/superset ) ([PR](https://github.com/apache/superset/pull/12709 ))
2021-07-25 22:22:09 +08:00
e905dd84c8
[Community] Add an github action to auto add 'approved' label ( #6239 )
...
1. If any committer APPROVE a PR, the label 'approved' will be added.
2. If any other reviewed APPROVE a PR, the label 'reviewed' will be added.
2021-07-14 21:12:42 +08:00
de2dd2c015
[Thirdparty] Move DataTables download url to a fixed download address ( #6189 )
...
The origin download url is always changing: https://datatables.net/download/builder?bs-3.3.7/jq-3.3.1/dt-1.10.25
So we put it in our own http server.
If someone can offer an official url for DataTables, please update this.
2021-07-10 10:13:26 +08:00
ee91c047fa
[GitHub] Fix PR Template ( #5494 )
2021-03-10 19:13:43 +08:00
6794dd08bd
[Doc] Update PULL_REQUEST_TEMPLATE.md ( #5248 )
...
A reword suggestion.
Reasons: Before my change, the statement is "If this change need a document change, I have updated the document",
and there is a grammar error in it evidently: "change" cannot be paired with "need".
Either "changes need" or "change need" will be ok at the grammar level.
According to the context, "changes need" will be better.
Now, the statement is "If these changes need document changes, I have updated the document".
2021-01-16 21:38:38 +08:00
449ba1e321
Update PULL_REQUEST_TEMPLATE.md ( #5240 )
2021-01-15 10:42:10 +08:00
912547260a
[UnitTest] Refactor BE unit test script ( #4266 )
...
1. Rename run-ut.sh to run-be-ut.sh
2. Find all test files from build dir instead of declaring separately in the script
3. Add gtest output to collect the result of unit test.
2020-08-11 10:23:51 +08:00
83a751497e
[Bug][Socket Leak] Fix bug that Mysql NIO server is leaking sockets ( #4192 )
...
When using mysql nio server, if the mysql handshake protocol fails,
we need to actively close the channel to prevent socket leakage.
2020-07-29 15:01:27 +08:00
5e555bfafb
[GithubTemplate] Fix PR template ( #4092 )
...
move PR template to .github root.
2020-07-14 10:50:35 +08:00
34d94dfd4e
[GithubTemplate] Remove license of Github template file ( #4091 )
...
Github template file can not add license.
2020-07-14 10:11:44 +08:00
ecb1bfb22a
[Community] Add pull request template ( #4072 )
...
add a pull request template like apache kylin to make our pr more more formal
2020-07-13 20:55:12 +08:00
050cbf2438
Update issue templates
2018-09-18 12:42:30 +08:00
