|
|
f32deb18e9
|
[Update](build) change clucene from thirdparty to git module (#19352)
|
2023-05-19 08:25:51 +08:00 |
|
|
|
2209b714d1
|
[chore](orc) Update orc lib to third party lib(1.8.3) using git submodule. (#18531)
|
2023-04-12 10:37:50 +08:00 |
|
|
|
c804024e5d
|
[Chore](workflow) add clang-tidy workflow (#14737)
add clang-tidy workflow
|
2022-12-02 14:10:29 +08:00 |
|
|
|
4fa53b4cdb
|
[chore](workflow) Add shellcheck to check shell scripts (#11744)
|
2022-08-18 16:07:28 +08:00 |
|
|
|
5215d95064
|
[enhancement](workflow) Use ccache to speed the BE UT (Clang) up (#11339)
|
2022-07-29 21:19:26 +08:00 |
|
|
|
14bb6088da
|
[community](actions): add action to check PR title (#11304)
|
2022-07-29 14:49:44 +08:00 |
|
|
|
9013d5cc09
|
[enhancement](workflow) Optimize workflows (#11145)
1. Fine tune the trigger conditions for workflows.
2. Introduce concurrency group to cancel previous workflow trigged by the same pr.
|
2022-07-28 08:32:33 +08:00 |
|
|
|
c62c2e308f
|
[chore]replace checkstyle action with mvn checkstyle:check (#10474)
|
2022-06-30 11:20:50 +08:00 |
|
|
|
784681f106
|
[FE Code Style][step 0]add github action to check incremental code in pr (#9328)
1. add rules to checkstyle
2. add github action to check incremental code in pr
|
2022-05-01 17:30:29 +08:00 |
|
|
|
ebc27a40d7
|
[docs] Split the FAQ And Revert auto-label action (#7770)
|
2022-01-17 10:34:56 +08:00 |
|
|
|
3da4425af5
|
[fix](github-action) fix the action of set-label-based-on-pr-title (#7757)
|
2022-01-13 23:35:00 +08:00 |
|
|
|
b51121fe86
|
[chore](github-action) Add label auto for pull requests (#7663)
|
2022-01-13 20:07:16 +08:00 |
|
|
|
270bebe196
|
[chore](github) Add third-party GitHub Action as submodule to allow it to run (#7280)
Add the 3rd-party GHA as submodule so that it can be run without asking to add it into allow list.
|
2021-12-04 19:43:30 +08:00 |
|
|
|
8d1c1ef1e6
|
[Community] Fix PR labeling github action workflow (#6279)
My change is the fix and improvement for github action which labels approved PRs (introduced in this [PR](https://github.com/apache/incubator-doris/pull/6239)).
It is inspired by solution introduced and tested in [Apache Airflow](https://github.com/apache/airflow) (thanks @potiuk @ashb 🚀 )
Corresponding Apache Airflow workflows on which I based this PR:
- https://github.com/apache/airflow/blob/main/.github/workflows/label_when_reviewed.yml
- https://github.com/apache/airflow/blob/main/.github/workflows/label_when_reviewed_workflow_run.yml
Problems which were solved in this PR:
- **Permissions**.
@morningman opened a related bug: [[Help] Error: Resource not accessible by integration](https://github.com/TobKed/label-when-approved-action/issues/7). It is related to limited permissions of workflows being triggered by `pull_request_review` (`GITHUB_TOKEN` has read-only permissions). More information about it you can find in the article: [Keeping your GitHub Actions and workflows secure: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/).
TL;DR: On pull request review event (`on: pull_request_review` ) "dummy" workflow `Label when reviewed` triggers another workflow `Label when approved workflow run` which has sufficient permissions (`on: workflow_run: workflows: ["Label when reviewed"]`).
- **Safe use of 3rd-party Github Actions by using submodules pattern.** It is decribed in:
https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status
> NEVER use 3rd-party actions directly in your workflows - use the "submodule" pattern.
This pattern is successfully used by projects like:
- [Apache Airflow](https://github.com/apache/airflow) ([PR](https://github.com/apache/airflow/pull/13514#))
- [Apache Beam](https://github.com/apache/beam) ([PR](https://github.com/apache/beam/pull/13736))
- [Apache Superset](https://github.com/apache/superset) ([PR](https://github.com/apache/superset/pull/12709))
|
2021-07-25 22:22:09 +08:00 |
|
