3b6a781862
TabletMeta's _preferred_rowset_type is not initialized after object constructing and may be a random value, and this field is not updated when create ALPHA_ROWSET tablet, and it will not be serialized into pb in this case. So if cloning an ALPHA_ROWSET tablet from another BE, this new created local tablet's _preferred_rowset_type field may be random as BETA_ROWSET and can not be overwrote after cloned, then new input rows will be wrote as BETA_ROWSET format which is not we expect. This patch fix this bug by giving _preferred_rowset_type a default value and updating this field when create any type of tablet, and add an unit test and related overwrite equal operator functions.
49 lines
1.6 KiB
C++
Executable File
49 lines
1.6 KiB
C++
Executable File
// Licensed to the Apache Software Foundation (ASF) under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
#include <string>
|
|
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "olap/tablet_meta.h"
|
|
|
|
namespace doris {
|
|
|
|
TEST(TabletMetaTest, SaveAndParse) {
|
|
std::string meta_path = "./be/test/olap/test_data/tablet_meta_test.hdr";
|
|
|
|
TabletMeta old_tablet_meta(1, 2, 3, 4, 5, TTabletSchema(), 6, {{7, 8}}, UniqueId(9, 10), TTabletType::TABLET_TYPE_DISK);
|
|
ASSERT_EQ(OLAP_SUCCESS, old_tablet_meta.save(meta_path));
|
|
|
|
{
|
|
// Just to make stack space dirty
|
|
TabletMeta new_tablet_meta;
|
|
new_tablet_meta._preferred_rowset_type = BETA_ROWSET;
|
|
}
|
|
TabletMeta new_tablet_meta;
|
|
new_tablet_meta.create_from_file(meta_path);
|
|
|
|
ASSERT_EQ(old_tablet_meta, new_tablet_meta);
|
|
}
|
|
|
|
} // namespace doris
|
|
|
|
int main(int argc, char **argv) {
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
return RUN_ALL_TESTS();
|
|
}
|