pick (#41992) We initially introduced jdbc connection pool to improve the connection performance of jdbc catalog, but we always found that connection pool would bring some unexpected errors, so we chose to add a catalog property: `enable_connection_pool` to choose whether to enable the jdbc connection pool of jdbc catalog, and the default false.However, the created catalog will still open the connection pool when it is upgraded, and only the newly created catalog will be false And we conducted performance tests on this, the performance loss is within the expected range. - Enable connection pool: mysqlslap -uroot -h127.0.0.1 -P9030 --concurrency=1 --iterations=100 --query='SELECT * FROM mysql.test.test limit 1;' --create-schema=mysql --delimiter=";" --verbose Benchmark Average number of seconds to run all queries: 0.008 seconds Minimum number of seconds to run all queries: 0.004 seconds Maximum number of seconds to run all queries: 0.133 seconds Number of clients running queries: 1 Average number of queries per client: 1 - Disable connection pool: mysqlslap -uroot -h127.0.0.1 -P9030 --concurrency=1 --iterations=100 --query='SELECT * FROM mysql_no_pool.test.test limit 1;' --create-schema=mysql --delimiter=";" --verbose Benchmark Average number of seconds to run all queries: 0.054 seconds Minimum number of seconds to run all queries: 0.047 seconds Maximum number of seconds to run all queries: 0.184 seconds Number of clients running queries: 1 Average number of queries per client: 1
213 lines
8.8 KiB
C++
213 lines
8.8 KiB
C++
// Licensed to the Apache Software Foundation (ASF) under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
#include "new_jdbc_scanner.h"
|
|
|
|
#include <new>
|
|
#include <ostream>
|
|
#include <utility>
|
|
#include <vector>
|
|
|
|
#include "common/logging.h"
|
|
#include "runtime/descriptors.h"
|
|
#include "runtime/runtime_state.h"
|
|
#include "util/runtime_profile.h"
|
|
#include "vec/columns/column.h"
|
|
#include "vec/core/block.h"
|
|
#include "vec/core/column_with_type_and_name.h"
|
|
#include "vec/data_types/data_type.h"
|
|
#include "vec/exec/scan/new_jdbc_scan_node.h"
|
|
#include "vec/exec/scan/vscan_node.h"
|
|
#include "vec/exec/vjdbc_connector.h"
|
|
#include "vec/exprs/vexpr_context.h"
|
|
|
|
namespace doris::vectorized {
|
|
NewJdbcScanner::NewJdbcScanner(RuntimeState* state, NewJdbcScanNode* parent, int64_t limit,
|
|
const TupleId& tuple_id, const std::string& query_string,
|
|
TOdbcTableType::type table_type, RuntimeProfile* profile)
|
|
: VScanner(state, static_cast<VScanNode*>(parent), limit, profile),
|
|
_jdbc_eos(false),
|
|
_tuple_id(tuple_id),
|
|
_query_string(query_string),
|
|
_tuple_desc(nullptr),
|
|
_table_type(table_type) {
|
|
_init_profile(get_parent()->_scanner_profile);
|
|
}
|
|
|
|
NewJdbcScanner::NewJdbcScanner(RuntimeState* state,
|
|
doris::pipeline::JDBCScanLocalState* local_state, int64_t limit,
|
|
const TupleId& tuple_id, const std::string& query_string,
|
|
TOdbcTableType::type table_type, RuntimeProfile* profile)
|
|
: VScanner(state, local_state, limit, profile),
|
|
_jdbc_eos(false),
|
|
_tuple_id(tuple_id),
|
|
_query_string(query_string),
|
|
_tuple_desc(nullptr),
|
|
_table_type(table_type) {
|
|
_init_profile(local_state->_scanner_profile);
|
|
}
|
|
|
|
Status NewJdbcScanner::prepare(RuntimeState* state, const VExprContextSPtrs& conjuncts) {
|
|
VLOG_CRITICAL << "NewJdbcScanner::Prepare";
|
|
RETURN_IF_ERROR(VScanner::prepare(state, conjuncts));
|
|
|
|
if (_is_init) {
|
|
return Status::OK();
|
|
}
|
|
|
|
if (state == nullptr) {
|
|
return Status::InternalError("input pointer is NULL of VJdbcScanNode::prepare.");
|
|
}
|
|
|
|
// get tuple desc
|
|
_tuple_desc = state->desc_tbl().get_tuple_descriptor(_tuple_id);
|
|
if (_tuple_desc == nullptr) {
|
|
return Status::InternalError("Failed to get tuple descriptor.");
|
|
}
|
|
|
|
// get jdbc table info
|
|
const JdbcTableDescriptor* jdbc_table =
|
|
static_cast<const JdbcTableDescriptor*>(_tuple_desc->table_desc());
|
|
if (jdbc_table == nullptr) {
|
|
return Status::InternalError("jdbc table pointer is NULL of VJdbcScanNode::prepare.");
|
|
}
|
|
_jdbc_param.catalog_id = jdbc_table->jdbc_catalog_id();
|
|
_jdbc_param.driver_class = jdbc_table->jdbc_driver_class();
|
|
_jdbc_param.driver_path = jdbc_table->jdbc_driver_url();
|
|
_jdbc_param.resource_name = jdbc_table->jdbc_resource_name();
|
|
_jdbc_param.driver_checksum = jdbc_table->jdbc_driver_checksum();
|
|
_jdbc_param.jdbc_url = jdbc_table->jdbc_url();
|
|
_jdbc_param.user = jdbc_table->jdbc_user();
|
|
_jdbc_param.passwd = jdbc_table->jdbc_passwd();
|
|
_jdbc_param.tuple_desc = _tuple_desc;
|
|
_jdbc_param.query_string = std::move(_query_string);
|
|
_jdbc_param.use_transaction = false; // not useful for scanner but only sink.
|
|
_jdbc_param.table_type = _table_type;
|
|
_jdbc_param.connection_pool_min_size = jdbc_table->connection_pool_min_size();
|
|
_jdbc_param.connection_pool_max_size = jdbc_table->connection_pool_max_size();
|
|
_jdbc_param.connection_pool_max_life_time = jdbc_table->connection_pool_max_life_time();
|
|
_jdbc_param.connection_pool_max_wait_time = jdbc_table->connection_pool_max_wait_time();
|
|
_jdbc_param.connection_pool_keep_alive = jdbc_table->connection_pool_keep_alive();
|
|
_jdbc_param.enable_connection_pool = jdbc_table->enable_connection_pool();
|
|
|
|
if (get_parent() != nullptr) {
|
|
get_parent()->_scanner_profile->add_info_string("JdbcDriverClass",
|
|
_jdbc_param.driver_class);
|
|
get_parent()->_scanner_profile->add_info_string("JdbcDriverUrl", _jdbc_param.driver_path);
|
|
get_parent()->_scanner_profile->add_info_string("JdbcUrl", _jdbc_param.jdbc_url);
|
|
get_parent()->_scanner_profile->add_info_string("QuerySql", _jdbc_param.query_string);
|
|
} else { //pipelineX
|
|
_local_state->scanner_profile()->add_info_string("JdbcDriverClass",
|
|
_jdbc_param.driver_class);
|
|
_local_state->scanner_profile()->add_info_string("JdbcDriverUrl", _jdbc_param.driver_path);
|
|
_local_state->scanner_profile()->add_info_string("JdbcUrl", _jdbc_param.jdbc_url);
|
|
_local_state->scanner_profile()->add_info_string("QuerySql", _jdbc_param.query_string);
|
|
}
|
|
|
|
_jdbc_connector.reset(new (std::nothrow) JdbcConnector(_jdbc_param));
|
|
if (_jdbc_connector == nullptr) {
|
|
return Status::InternalError("new a jdbc scanner failed.");
|
|
}
|
|
|
|
_is_init = true;
|
|
return Status::OK();
|
|
}
|
|
|
|
Status NewJdbcScanner::open(RuntimeState* state) {
|
|
VLOG_CRITICAL << "NewJdbcScanner::open";
|
|
if (state == nullptr) {
|
|
return Status::InternalError("input pointer is NULL of VJdbcScanNode::open.");
|
|
}
|
|
|
|
if (!_is_init) {
|
|
return Status::InternalError("used before initialize of VJdbcScanNode::open.");
|
|
}
|
|
RETURN_IF_CANCELLED(state);
|
|
RETURN_IF_ERROR(VScanner::open(state));
|
|
RETURN_IF_ERROR(_jdbc_connector->open(state, true));
|
|
RETURN_IF_ERROR(_jdbc_connector->query());
|
|
return Status::OK();
|
|
}
|
|
|
|
Status NewJdbcScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) {
|
|
VLOG_CRITICAL << "NewJdbcScanner::_get_block_impl";
|
|
if (nullptr == state || nullptr == block || nullptr == eof) {
|
|
return Status::InternalError("input is NULL pointer");
|
|
}
|
|
|
|
if (!_is_init) {
|
|
return Status::InternalError("used before initialize of VJdbcScanNode::get_next.");
|
|
}
|
|
|
|
if (_jdbc_eos == true) {
|
|
*eof = true;
|
|
_update_profile();
|
|
return Status::OK();
|
|
}
|
|
|
|
// only empty block should be here
|
|
DCHECK(block->rows() == 0);
|
|
|
|
do {
|
|
RETURN_IF_CANCELLED(state);
|
|
|
|
RETURN_IF_ERROR(_jdbc_connector->get_next(&_jdbc_eos, block, state->batch_size()));
|
|
|
|
if (_jdbc_eos == true) {
|
|
if (block->rows() == 0) {
|
|
_update_profile();
|
|
*eof = true;
|
|
}
|
|
break;
|
|
}
|
|
|
|
VLOG_ROW << "NewJdbcScanNode output rows: " << block->rows();
|
|
} while (block->rows() == 0 && !(*eof));
|
|
return Status::OK();
|
|
}
|
|
|
|
void NewJdbcScanner::_init_profile(const std::shared_ptr<RuntimeProfile>& profile) {
|
|
_is_init = false;
|
|
_load_jar_timer = ADD_TIMER(profile, "LoadJarTime");
|
|
_init_connector_timer = ADD_TIMER(profile, "InitConnectorTime");
|
|
_check_type_timer = ADD_TIMER(profile, "CheckTypeTime");
|
|
_get_data_timer = ADD_TIMER(profile, "GetDataTime");
|
|
_get_block_address_timer = ADD_CHILD_TIMER(profile, "GetBlockAddressTime", "GetDataTime");
|
|
_fill_block_timer = ADD_CHILD_TIMER(profile, "FillBlockTime", "GetDataTime");
|
|
_execte_read_timer = ADD_TIMER(profile, "ExecteReadTime");
|
|
_connector_close_timer = ADD_TIMER(profile, "ConnectorCloseTime");
|
|
}
|
|
|
|
void NewJdbcScanner::_update_profile() {
|
|
JdbcConnector::JdbcStatistic& jdbc_statistic = _jdbc_connector->get_jdbc_statistic();
|
|
COUNTER_UPDATE(_load_jar_timer, jdbc_statistic._load_jar_timer);
|
|
COUNTER_UPDATE(_init_connector_timer, jdbc_statistic._init_connector_timer);
|
|
COUNTER_UPDATE(_check_type_timer, jdbc_statistic._check_type_timer);
|
|
COUNTER_UPDATE(_get_data_timer, jdbc_statistic._get_data_timer);
|
|
COUNTER_UPDATE(_get_block_address_timer, jdbc_statistic._get_block_address_timer);
|
|
COUNTER_UPDATE(_fill_block_timer, jdbc_statistic._fill_block_timer);
|
|
COUNTER_UPDATE(_execte_read_timer, jdbc_statistic._execte_read_timer);
|
|
COUNTER_UPDATE(_connector_close_timer, jdbc_statistic._connector_close_timer);
|
|
}
|
|
|
|
Status NewJdbcScanner::close(RuntimeState* state) {
|
|
RETURN_IF_ERROR(VScanner::close(state));
|
|
RETURN_IF_ERROR(_jdbc_connector->close());
|
|
return Status::OK();
|
|
}
|
|
} // namespace doris::vectorized
|