6dddd4c499
…avior (#38847) https://github.com/apache/doris/pull/38847 ## Proposed changes There are two issues here. First, the results of casting are inconsistent between FE and BE . ``` FE mysql [(none)]>select cast('3.000' as int); +----------------------+ | cast('3.000' as INT) | +----------------------+ | 3 | +----------------------+ mysql [(none)]>set debug_skip_fold_constant = true; BE mysql [(none)]>select cast('3.000' as int); +----------------------+ | cast('3.000' as INT) | +----------------------+ | NULL | +----------------------+ ``` The second issue is that casting on BE converts '3.0' to null. Here, the casting logic for FE and BE has been unified <!--Describe your changes.--> ## Proposed changes Issue Number: close #xxx <!--Describe your changes.--> --------- Co-authored-by: Xinyi Zou <zouxinyi02@gmail.com>
103 lines
3.3 KiB
C++
103 lines
3.3 KiB
C++
// Licensed to the Apache Software Foundation (ASF) under one
|
|
// or more contributor license agreements. See the NOTICE file
|
|
// distributed with this work for additional information
|
|
// regarding copyright ownership. The ASF licenses this file
|
|
// to you under the Apache License, Version 2.0 (the
|
|
// "License"); you may not use this file except in compliance
|
|
// with the License. You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing,
|
|
// software distributed under the License is distributed on an
|
|
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
// KIND, either express or implied. See the License for the
|
|
// specific language governing permissions and limitations
|
|
// under the License.
|
|
|
|
#include "util/parse_util.h"
|
|
|
|
#include <gtest/gtest-message.h>
|
|
#include <gtest/gtest-test-part.h>
|
|
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "gtest/gtest_pred_impl.h"
|
|
#include "util/mem_info.h"
|
|
|
|
namespace doris {
|
|
|
|
static void test_parse_mem_spec(const std::string& mem_spec_str, int64_t result) {
|
|
bool is_percent = true;
|
|
int64_t bytes =
|
|
ParseUtil::parse_mem_spec(mem_spec_str, -1, MemInfo::_s_physical_mem, &is_percent);
|
|
EXPECT_EQ(result, bytes);
|
|
EXPECT_FALSE(is_percent);
|
|
}
|
|
|
|
TEST(TestParseMemSpec, Normal) {
|
|
test_parse_mem_spec("1", 1);
|
|
|
|
test_parse_mem_spec("100b", 100);
|
|
test_parse_mem_spec("100B", 100);
|
|
|
|
test_parse_mem_spec("5k", 5 * 1024L);
|
|
test_parse_mem_spec("512K", 512 * 1024L);
|
|
|
|
test_parse_mem_spec("4m", 4 * 1024 * 1024L);
|
|
test_parse_mem_spec("46M", 46 * 1024 * 1024L);
|
|
|
|
test_parse_mem_spec("8g", 8 * 1024 * 1024 * 1024L);
|
|
test_parse_mem_spec("128G", 128 * 1024 * 1024 * 1024L);
|
|
|
|
test_parse_mem_spec("8t", 8L * 1024 * 1024 * 1024 * 1024L);
|
|
test_parse_mem_spec("128T", 128L * 1024 * 1024 * 1024 * 1024L);
|
|
|
|
bool is_percent = false;
|
|
int64_t bytes = ParseUtil::parse_mem_spec("20%", -1, MemInfo::_s_physical_mem, &is_percent);
|
|
EXPECT_GT(bytes, 0);
|
|
EXPECT_TRUE(is_percent);
|
|
|
|
MemInfo::_s_physical_mem = 1000;
|
|
is_percent = true;
|
|
bytes = ParseUtil::parse_mem_spec("0.1%", -1, MemInfo::_s_physical_mem, &is_percent);
|
|
EXPECT_EQ(bytes, 1);
|
|
EXPECT_TRUE(is_percent);
|
|
|
|
// test with parent limit
|
|
is_percent = false;
|
|
bytes = ParseUtil::parse_mem_spec("1%", 1000, MemInfo::_s_physical_mem, &is_percent);
|
|
EXPECT_TRUE(is_percent);
|
|
EXPECT_EQ(10, bytes);
|
|
|
|
is_percent = true;
|
|
bytes = ParseUtil::parse_mem_spec("1001", 1000, MemInfo::_s_physical_mem, &is_percent);
|
|
EXPECT_FALSE(is_percent);
|
|
EXPECT_EQ(1001, bytes);
|
|
}
|
|
|
|
TEST(TestParseMemSpec, Bad) {
|
|
std::vector<std::string> bad_values;
|
|
bad_values.push_back("1gib");
|
|
bad_values.push_back("1%b");
|
|
bad_values.push_back("1b%");
|
|
bad_values.push_back("gb");
|
|
bad_values.push_back("1GMb");
|
|
bad_values.push_back("1b1Mb");
|
|
bad_values.push_back("1kib");
|
|
bad_values.push_back("1Bb");
|
|
bad_values.push_back("1%%");
|
|
bad_values.push_back("1.1");
|
|
bad_values.push_back("1pb");
|
|
bad_values.push_back("1eb");
|
|
bad_values.push_back("%");
|
|
for (const auto& value : bad_values) {
|
|
bool is_percent = false;
|
|
int64_t bytes = ParseUtil::parse_mem_spec(value, -1, MemInfo::_s_physical_mem, &is_percent);
|
|
EXPECT_EQ(-1, bytes) << ", value: " << value;
|
|
}
|
|
}
|
|
|
|
} // namespace doris
|