From 1bbc313c66246716bb6d97a2bc6cfdce3ea8f37c Mon Sep 17 00:00:00 2001
From: Eugene Kalinin <ekalinin@users.noreply.github.com>
Date: Fri, 25 Oct 2019 10:46:29 +0300
Subject: [PATCH] expression: implement vectorized evaluation for
 builtinCastDecimalAsTimeSig (#12904)

---
 expression/builtin_cast_vec.go      | 38 +++++++++++++++++++++++++++--
 expression/builtin_cast_vec_test.go |  1 +
 2 files changed, 37 insertions(+), 2 deletions(-)

diff --git a/expression/builtin_cast_vec.go b/expression/builtin_cast_vec.go
index 17ee5540be..a524d1c6d7 100644
--- a/expression/builtin_cast_vec.go
+++ b/expression/builtin_cast_vec.go
@@ -906,11 +906,45 @@ func (b *builtinCastDecimalAsRealSig) vecEvalReal(input *chunk.Chunk, result *ch
 }
 
 func (b *builtinCastDecimalAsTimeSig) vectorized() bool {
-	return false
+	return true
 }
 
 func (b *builtinCastDecimalAsTimeSig) vecEvalTime(input *chunk.Chunk, result *chunk.Column) error {
-	return errors.Errorf("not implemented")
+	n := input.NumRows()
+	buf, err := b.bufAllocator.get(types.ETDecimal, n)
+	if err != nil {
+		return err
+	}
+	defer b.bufAllocator.put(buf)
+	if err := b.args[0].VecEvalDecimal(b.ctx, input, buf); err != nil {
+		return err
+	}
+
+	result.ResizeTime(n, false)
+	result.MergeNulls(buf)
+	times := result.Times()
+	decimals := buf.Decimals()
+	stmt := b.ctx.GetSessionVars().StmtCtx
+	fsp := int8(b.tp.Decimal)
+	for i := 0; i < n; i++ {
+		if buf.IsNull(i) {
+			continue
+		}
+		tm, err := types.ParseTimeFromFloatString(stmt, string(decimals[i].ToString()), b.tp.Tp, fsp)
+		if err != nil {
+			if err = handleInvalidTimeError(b.ctx, err); err != nil {
+				return err
+			}
+			result.SetNull(i, true)
+			continue
+		}
+		times[i] = tm
+		if b.tp.Tp == mysql.TypeDate {
+			// Truncate hh:mm:ss part if the type is Date.
+			times[i].Time = types.FromDate(tm.Time.Year(), tm.Time.Month(), tm.Time.Day(), 0, 0, 0, 0)
+		}
+	}
+	return nil
 }
 
 func (b *builtinCastTimeAsIntSig) vectorized() bool {
diff --git a/expression/builtin_cast_vec_test.go b/expression/builtin_cast_vec_test.go
index b5361bfeeb..3c18896076 100644
--- a/expression/builtin_cast_vec_test.go
+++ b/expression/builtin_cast_vec_test.go
@@ -55,6 +55,7 @@ var vecBuiltinCastCases = map[string][]vecExprBenchCase{
 		{retEvalType: types.ETJson, childrenTypes: []types.EvalType{types.ETJson}},
 		{retEvalType: types.ETJson, childrenTypes: []types.EvalType{types.ETString}, geners: []dataGenerator{&jsonStringGener{}}},
 		{retEvalType: types.ETJson, childrenTypes: []types.EvalType{types.ETDecimal}},
+		{retEvalType: types.ETDatetime, childrenTypes: []types.EvalType{types.ETDecimal}},
 		{retEvalType: types.ETDatetime, childrenTypes: []types.EvalType{types.ETInt}},
 	},
 }