From 25d883da3ce2aac5371044cebb2bbb99bdd163bf Mon Sep 17 00:00:00 2001 From: shenli Date: Tue, 22 Dec 2015 00:17:12 +0800 Subject: [PATCH] *: Address comment --- executor/converter/convert_expr.go | 3 ++- session_test.go | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/executor/converter/convert_expr.go b/executor/converter/convert_expr.go index 1206952707..9baa1fba67 100644 --- a/executor/converter/convert_expr.go +++ b/executor/converter/convert_expr.go @@ -14,12 +14,13 @@ package converter import ( + "strings" + "github.com/juju/errors" "github.com/pingcap/tidb/ast" "github.com/pingcap/tidb/expression" "github.com/pingcap/tidb/expression/subquery" "github.com/pingcap/tidb/model" - "strings" ) func convertExpr(converter *expressionConverter, expr ast.ExprNode) (expression.Expression, error) { diff --git a/session_test.go b/session_test.go index 18ad9f5ffd..b7d597b22b 100644 --- a/session_test.go +++ b/session_test.go @@ -1373,8 +1373,8 @@ func (s *testSessionSuite) TestSubstringIndexExpr(c *C) { se := newSession(c, store, s.dbName) mustExecSQL(c, se, "drop table if exists t;") mustExecSQL(c, se, "create table t (c varchar(128));") - mustExecSQL(c, se, `insert into t values ("www.mysql.com");`) - mustExecMatch(c, se, "SELECT DISTINCT SUBSTRING_INDEX(c, '.', 2) from t;", [][]interface{}{{"www.mysql"}}) + mustExecSQL(c, se, `insert into t values ("www.pingcap.com");`) + mustExecMatch(c, se, "SELECT DISTINCT SUBSTRING_INDEX(c, '.', 2) from t;", [][]interface{}{{"www.pingcap"}}) } func (s *testSessionSuite) TestGlobalVarAccessor(c *C) {