From 263a49d003eca7c1f71aaa43641b4e1345efb771 Mon Sep 17 00:00:00 2001 From: mmyj <21154264+mmyj@users.noreply.github.com> Date: Tue, 22 Oct 2019 17:22:40 +0800 Subject: [PATCH] expression: implement vectorized evaluation for `builtinMD5Sig` (#12731) --- expression/builtin_encryption_vec.go | 29 +++++++++++++++++++++-- expression/builtin_encryption_vec_test.go | 4 +++- 2 files changed, 30 insertions(+), 3 deletions(-) diff --git a/expression/builtin_encryption_vec.go b/expression/builtin_encryption_vec.go index 28817af237..9de10e2f0a 100644 --- a/expression/builtin_encryption_vec.go +++ b/expression/builtin_encryption_vec.go @@ -14,6 +14,7 @@ package expression import ( + "crypto/md5" "crypto/sha1" "crypto/sha256" "crypto/sha512" @@ -138,11 +139,35 @@ func (b *builtinRandomBytesSig) vecEvalString(input *chunk.Chunk, result *chunk. } func (b *builtinMD5Sig) vectorized() bool { - return false + return true } func (b *builtinMD5Sig) vecEvalString(input *chunk.Chunk, result *chunk.Column) error { - return errors.Errorf("not implemented") + n := input.NumRows() + buf, err := b.bufAllocator.get(types.ETString, n) + if err != nil { + return err + } + defer b.bufAllocator.put(buf) + if err := b.args[0].VecEvalString(b.ctx, input, buf); err != nil { + return err + } + result.ReserveString(n) + digest := md5.New() + for i := 0; i < n; i++ { + if buf.IsNull(i) { + result.AppendNull() + continue + } + cryptByte := buf.GetBytes(i) + _, err := digest.Write(cryptByte) + if err != nil { + return err + } + result.AppendString(fmt.Sprintf("%x", digest.Sum(nil))) + digest.Reset() + } + return nil } func (b *builtinSHA2Sig) vectorized() bool { diff --git a/expression/builtin_encryption_vec_test.go b/expression/builtin_encryption_vec_test.go index 35fa214fe4..69365eb79f 100644 --- a/expression/builtin_encryption_vec_test.go +++ b/expression/builtin_encryption_vec_test.go @@ -26,7 +26,9 @@ var vecBuiltinEncryptionCases = map[string][]vecExprBenchCase{ ast.Uncompress: {}, ast.AesDecrypt: {}, ast.Compress: {}, - ast.MD5: {}, + ast.MD5: { + {retEvalType: types.ETString, childrenTypes: []types.EvalType{types.ETString}}, + }, ast.SHA: { {retEvalType: types.ETString, childrenTypes: []types.EvalType{types.ETString}}, },