From 3a97fa2f1980d9fbdf690bb80bb5d23703bfb0c0 Mon Sep 17 00:00:00 2001 From: siddontang Date: Fri, 16 Oct 2015 19:23:43 +0800 Subject: [PATCH] plans: Address comment --- plan/plans/select_list.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plan/plans/select_list.go b/plan/plans/select_list.go index 89c809d9e4..7d918fceed 100644 --- a/plan/plans/select_list.go +++ b/plan/plans/select_list.go @@ -165,7 +165,7 @@ func (s *SelectList) CheckReferAmbiguous(expr expression.Expression) (int, error lastIndex := -1 // only check origin select list, no hidden field. for i := 0; i < s.HiddenFieldOffset; i++ { - if s.ResultFields[i].Name != name { + if !strings.EqualFold(s.ResultFields[i].Name, name) { continue } else if _, ok := s.Fields[i].Expr.(*expression.Ident); !ok { // not identfier, no check @@ -179,7 +179,7 @@ func (s *SelectList) CheckReferAmbiguous(expr expression.Expression) (int, error } // check origin name, e,g. "select c1 as c2, c2 from t group by c2" is ambiguous. - if s.ResultFields[i].ColumnInfo.Name.O != s.ResultFields[lastIndex].ColumnInfo.Name.O { + if s.ResultFields[i].ColumnInfo.Name.L != s.ResultFields[lastIndex].ColumnInfo.Name.L { return -1, errors.Errorf("refer %s is ambiguous", expr) }