database/tidb
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

*: use session time_zone for is.tables and show table status (#32449)

Browse Source 
ref pingcap/tidb#26642
This commit is contained in:
Mattias Jonsson
2022-02-28 23:09:45 +01:00
committed by GitHub
parent f9a324829b
commit 584ae75df5
5 changed files with 41 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
plugin/integration_test.go
View File

@ -50,6 +50,7 @@ func TestAuditLogNormal(t *testing.T) {
tables string
cmd string
event plugin.GeneralEvent
resCnt int
}
tests := []normalTest{
@ -507,6 +508,7 @@ func TestAuditLogNormal(t *testing.T) {
{
sql: "SHOW TABLE STATUS LIKE 't1'",
stmtType: "Show",
resCnt: 3, // Start + SHOW TABLE + Internal SELECT .. FROM IS.TABLES in current session
},
{
sql: "SHOW TABLES",
@ -696,12 +698,18 @@ func TestAuditLogNormal(t *testing.T) {
query := append([]byte{mysql.ComQuery}, []byte(test.sql)...)
err := conn.Dispatch(context.Background(), query)
require.NoError(t, err, errMsg)
require.Equal(t, 2, len(testResults), errMsg)
resultCount := test.resCnt
if resultCount == 0 {
resultCount = 2
}
require.Equal(t, resultCount, len(testResults), errMsg)
result := testResults[0]
// TODO: currently, result.text is wrong.
require.Equal(t, "Query", result.cmd, errMsg)
require.Equal(t, plugin.Starting, result.event, errMsg)
result = testResults[1]
result = testResults[resultCount-1]
require.Equal(t, "Query", result.cmd, errMsg)
if test.text == "" {
require.Equal(t, test.sql, result.text, errMsg)
} else {
@ -713,6 +721,11 @@ func TestAuditLogNormal(t *testing.T) {
require.Equal(t, test.tables, result.tables, errMsg)
require.Equal(t, "Query", result.cmd, errMsg)
require.Equal(t, plugin.Completed, result.event, errMsg)
for i := 1; i < resultCount-1; i++ {
result = testResults[i]
require.Equal(t, "Query", result.cmd, errMsg)
require.Equal(t, plugin.Completed, result.event, errMsg)
}
}
}